Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT] Update dark style base map tile contrast #458

Closed
junqiu-lei opened this issue Aug 18, 2023 · 18 comments
Closed

[ENHANCEMENT] Update dark style base map tile contrast #458

junqiu-lei opened this issue Aug 18, 2023 · 18 comments
Assignees
Labels
enhancement New feature or request v2.12.0

Comments

@junqiu-lei
Copy link
Member

junqiu-lei commented Aug 18, 2023

Is your feature request related to a problem?

Follow up from #448 (comment), for the dark tile style, we want to make it more contrast from current picked "Dark Matter" style.

https://openmaptiles.org/styles/#dark-matter

@junqiu-lei junqiu-lei added the enhancement New feature or request label Aug 18, 2023
@wbeckler
Copy link

This is looking buggy, and it was reported as a bug when someone saw it here:
https://playground.opensearch.org/app/maps-dashboards/88a24e6c-0216-4f76-8bc7-c8db6c8705da

@wbeckler wbeckler added the bug Something isn't working label Oct 31, 2023
@wbeckler
Copy link

Can this get fixed for 2.12?

@vamshin
Copy link
Member

vamshin commented Oct 31, 2023

@wbeckler Yes we will have this fixed in 2.12.

@junqiu-lei will be working on this

@vamshin vamshin removed the bug Something isn't working label Oct 31, 2023
@junqiu-lei
Copy link
Member Author

Hi @KrooshalUX, we'll need your team's help to prepare a color palette for the higher contrast dark style tile map, thanks!

@canascar
Copy link
Member

@junqiu-lei picking up UX on this.

@canascar
Copy link
Member

canascar commented Nov 17, 2023

@junqiu-lei can we try this:
os_open_zoomstack_-_night.json.zip

map

Adding @kgcreative for comment

@kgcreative
Copy link
Member

@canascar This looks much better, thank you! @junqiu-lei, i'd love to see an updated in-product screenshot once we've fixed this.

@junqiu-lei, i also notice the overlays on dark mode have what appears to be hard coded colors instead of our OUI variables, leading to the popovers looking a little jank (screenshot attached) -- are we tracking that in a sepparate issue?
Screenshot 2023-11-17 at 4 05 11 PM

@canascar
Copy link
Member

@canascar This looks much better, thank you! @junqiu-lei, i'd love to see an updated in-product screenshot once we've fixed this.

@junqiu-lei, i also notice the overlays on dark mode have what appears to be hard coded colors instead of our OUI variables, leading to the popovers looking a little jank (screenshot attached) -- are we tracking that in a sepparate issue? Screenshot 2023-11-17 at 4 05 11 PM

I think this is (or will be) tracked in another issue @kgcreative

@junqiu-lei
Copy link
Member Author

Great thanks @canascar, let me try this new dark style in-product. Thanks @kgcreative call out the overlays on dark mode, we can create one separate issue to track it.

@junqiu-lei
Copy link
Member Author

Hi @canascar, after POC on the os_open_zoomstack-night style, I found it's data source is based on it's own scheme, it doesn’t compatible with openmaptiles schema which is used in OpenSearch maps service. Can we provide the styles based openmaptiles schema?

Some styles based on openmaptile schema:
https://openmaptiles.org/styles/

Openmaptiles schema:
https://openmaptiles.org/schema/

UK OS Open Zoomstack schema:
https://docs.maptiler.com/schema/uk-openzoomstack/

@canascar

This comment was marked as outdated.

@canascar
Copy link
Member

canascar commented Nov 28, 2023

Updated JSON with correct "Dark_Matter" theme:
dark_matter.json.zip

https://paste.amazon.com/show/canascar/1701212576

Page template

@junqiu-lei
Copy link
Member Author

@canascar I tested the latest dark style you provided in maps-dashboards, looks good to me. Shall we update our maps service with it? @canascar @kgcreative

image

@canascar
Copy link
Member

canascar commented Nov 30, 2023

Looks great @junqiu-lei - Ship it!

@canascar
Copy link
Member

@junqiu-lei here Sent an updated to the map visualization JSON file. Let me know if there are any issues and when it may be able to be added to production. Thanks!

@junqiu-lei
Copy link
Member Author

@canascar I'll have a local verification firstly.

@junqiu-lei
Copy link
Member Author

Left: new style | Right: existing style
dark_style_update

@junqiu-lei
Copy link
Member Author

Closing this issue as the dark style updated in OpenSearch Maps service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.12.0
Projects
None yet
Development

No branches or pull requests

5 participants