-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Update dark style base map tile contrast #458
Comments
This is looking buggy, and it was reported as a bug when someone saw it here: |
Can this get fixed for 2.12? |
@wbeckler Yes we will have this fixed in 2.12. @junqiu-lei will be working on this |
Hi @KrooshalUX, we'll need your team's help to prepare a color palette for the higher contrast dark style tile map, thanks! |
@junqiu-lei picking up UX on this. |
@junqiu-lei can we try this: Adding @kgcreative for comment |
@canascar This looks much better, thank you! @junqiu-lei, i'd love to see an updated in-product screenshot once we've fixed this. @junqiu-lei, i also notice the overlays on dark mode have what appears to be hard coded colors instead of our OUI variables, leading to the popovers looking a little jank (screenshot attached) -- are we tracking that in a sepparate issue? |
I think this is (or will be) tracked in another issue @kgcreative |
Great thanks @canascar, let me try this new dark style in-product. Thanks @kgcreative call out the overlays on dark mode, we can create one separate issue to track it. |
Hi @canascar, after POC on the os_open_zoomstack-night style, I found it's data source is based on it's own scheme, it doesn’t compatible with openmaptiles schema which is used in OpenSearch maps service. Can we provide the styles based openmaptiles schema? Some styles based on openmaptile schema: Openmaptiles schema: UK OS Open Zoomstack schema: |
This comment was marked as outdated.
This comment was marked as outdated.
Updated JSON with correct "Dark_Matter" theme: |
@canascar I tested the latest dark style you provided in maps-dashboards, looks good to me. Shall we update our maps service with it? @canascar @kgcreative |
Looks great @junqiu-lei - Ship it! |
@junqiu-lei here Sent an updated to the map visualization JSON file. Let me know if there are any issues and when it may be able to be added to production. Thanks! |
@canascar I'll have a local verification firstly. |
Closing this issue as the dark style updated in OpenSearch Maps service. |
Is your feature request related to a problem?
Follow up from #448 (comment), for the dark tile style, we want to make it more contrast from current picked "Dark Matter" style.
https://openmaptiles.org/styles/#dark-matter
The text was updated successfully, but these errors were encountered: