Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Node.js v18 Compatibility Test for [dashboards-docker-images] #13

Closed
Tracked by #4058
ananzh opened this issue May 17, 2023 · 4 comments
Closed
Tracked by #4058

Node.js v18 Compatibility Test for [dashboards-docker-images] #13

ananzh opened this issue May 17, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@ananzh
Copy link
Member

ananzh commented May 17, 2023

Introduction

As part of our continued efforts to improve OpenSearch Dashboards, we are planning to upgrade the underlying Node.js version from v14 to v18. This change will enhance performance, add new features, and bolster security. However, such major version changes might also affect the compatibility of existing plugins. Here is more introduction: opensearch-project/OpenSearch-Dashboards#3601.

Therefore, we kindly request assistance in testing this plugin the compatibility of with this new version of Node.js. We've prepared a branch with the Node.js v18 upgrade, which you can find here:
https://github.com/AMoo-Miki/OpenSearch-Dashboards/tree/node-18-webpack-4

Steps to Proceed

  • If you think your plugin won't be affected by OpenSearch Dashboards Node.js upgrade. Pls ignore the rest steps and close the issue directly.
  • Pull the provided branch that includes the Node.js v18 upgrade and OpenSearch 3.0.0.
  • Hook up your plugin with the updated OpenSearch Dashboards.
  • Run your existing test suites and perform manual testing as necessary.
  • If no issues are encountered, feel free to close this issue.
  • If there are any problems, report them in this issue thread and also link them in the overall OpenSearch Dashboards Node.js upgrade issue thread Upcoming Transition to Node.js v18: Plugin Compatibility Test Required Overall Issue OpenSearch-Dashboards#4058
    The purpose of linking any questions or issues back to the main issue is to maintain visibility and transparency among all plugin owners. A problem encountered by one plugin might also affect others. This shared knowledge base will foster collaborative problem-solving and prevent duplication of effort.

We appreciate your support and cooperation in ensuring a smooth transition to Node.js v18 for the entire OpenSearch Dashboards community.

@ananzh
Copy link
Member Author

ananzh commented May 22, 2023

The official Node.js 18 PR raised in OSD: opensearch-project/OpenSearch-Dashboards#4071

@ananzh
Copy link
Member Author

ananzh commented May 22, 2023

opensearch-project/OpenSearch-Dashboards#4071 support node 14, 16 and 18. Pls test on node 18.

nvm install 18.16.0
nvm use 18.16.0

@prudhvigodithi
Copy link
Member

[Untriage]
Adding @peterzhuamazon

@peterzhuamazon
Copy link
Member

Hi @ananzh we are not using this repo for building docker images.
All the building scripts are currently reside here:
https://github.com/opensearch-project/opensearch-build/tree/main/docker

As for the nodejs18 all the changes are tracked in here:
opensearch-project/opensearch-build#1563

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants