Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the "Master" nomenclature #99

Closed
3 tasks
Tracked by #2589 ...
tlfeng opened this issue Mar 4, 2022 · 8 comments
Closed
3 tasks
Tracked by #2589 ...

Change the "Master" nomenclature #99

tlfeng opened this issue Mar 4, 2022 · 8 comments
Assignees
Labels
enhancement New feature or request v2.3.0 'Issues and PRs related to version v2.3.0'

Comments

@tlfeng
Copy link

tlfeng commented Mar 4, 2022

Is your feature request related to a problem? Please describe.
OpenSearch repository is going to replace the terminology "master"with "cluster manager".
issue: opensearch-project/OpenSearch#472 (comment), with the plan for its terminology replacement.

Although the existing usages with "master" will be supported in OpenSearch version 2.x to keep the backwards compatibility, please prepare for the nomenclature change in advance, and replace all the usages with "master" terminology in the code base.
All the OpenSearch REST APIs and settings that contain "master" terminology will be deprecated in 2.0, and alternative usages will be added.

Describe the solution you'd like
Replace the terminology "master" with "cluster manager".

When being compatible with OpenSearch 2.0:

  • Replace "master" in code comment and internal variable / method name.
  • Replace OpenSearh REST API that contains "master" with the provided inclusive REST API:
    replace "master_timeout" with "cluster_manager_timeout"

When being compatible with OpenSearch 3.0:

  • Replace "master" in the reference to OpenSearch Java API
    (new APIs are available in version 2.2)
    • DiscoveryNodes.builder().masterNodeId() -> clusterManagerNodeId()
    • DiscoveryNodeRole.MASTER_ROLE -> CLUSTER_MANAGER_ROLE
    • event.localNodeMaster() -> localNodeClusterManager()

Describe alternatives you've considered
None.

Additional context

@dhruv16dhr
Copy link
Contributor

Closing this issue as the changes are merged

@dblock
Copy link
Member

dblock commented Apr 18, 2022

I see methods like .localNodeMaster() in the code still. Is this waiting on something in OpenSearch?

@dblock dblock reopened this Apr 18, 2022
@tlfeng
Copy link
Author

tlfeng commented Apr 18, 2022

@dblock That's correct. .localNodeMaster() depends on the change in the OpenSearch class:


The rename is tracked in issue opensearch-project/OpenSearch#1684.
It will be ready before OpenSearch 3.0 and I will complete in advance and keep update.
If the issue is used for pending items for 2.0 release, then the issue is resolved.

@dblock dblock changed the title Change the "Master" nomenclature Deprecate the "Master" nomenclature Apr 19, 2022
@dblock dblock changed the title Deprecate the "Master" nomenclature Change the "Master" nomenclature Apr 19, 2022
@dblock dblock removed the v2.0.0 label Apr 19, 2022
@dblock
Copy link
Member

dblock commented Apr 19, 2022

I've removed the 2.0 label in favor of 2.1 for the remaining work.

@dblock dblock added the v2.1.0 label Apr 19, 2022
@dhruv16dhr
Copy link
Contributor

@tlfeng I see that opensearch-project/OpenSearch#1684 is still open
@dblock Should we change the label here?

@eirsep eirsep added v3.0.0 and removed v2.1.0 labels Jul 8, 2022
@eirsep
Copy link
Member

eirsep commented Jul 8, 2022

changed label to v3.0.0 as there are no 2.1 related master deprecation items for the plugin

@anasalkouz anasalkouz added v2.3.0 'Issues and PRs related to version v2.3.0' and removed v3.0.0 labels Aug 25, 2022
@anasalkouz
Copy link
Member

Java APIs completed and released on 2.2.
@dhruv16dhr Could you please complete the remaining part from your end? let's target 2.3 to remove all usages.

@anasalkouz
Copy link
Member

@dhruv16dhr anything remaining? can you close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.3.0 'Issues and PRs related to version v2.3.0'
Projects
None yet
Development

No branches or pull requests

5 participants