[Extensions] Migrates Search Detector Info action to extension

[owaiskazi19]

Description

This PR migrates SearchDetectorInfo to extension for GET request.

• GET _extensions/_ad-detection/detectors/count
• GET _plugins/_ad-detection/detectors/match

Issues Resolved

Closes opensearch-project/opensearch-sdk-java#675

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #875 (9964382) into feature/extensions (9ad715a) will decrease coverage by 0.11%.
The diff coverage is 3.33%.

❗ Current head 9964382 differs from pull request most recent head dc993ca. Consider uploading reports for the commit dc993ca to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@                   Coverage Diff                    @@
##             feature/extensions     #875      +/-   ##
========================================================
- Coverage                 35.02%   34.91%   -0.11%     
+ Complexity                 1896     1894       -2     
========================================================
  Files                       300      300              
  Lines                     17896    17915      +19     
  Branches                   1869     1869              
========================================================
- Hits                       6268     6255      -13     
- Misses                    11178    11206      +28     
- Partials                    450      454       +4     

Flag	Coverage Δ
plugin	34.91% <3.33%> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorExtension.java	0.00% <0.00%> (ø)
...opensearch/ad/indices/AnomalyDetectionIndices.java	12.52% <0.00%> (ø)
...h/ad/rest/RestSearchAnomalyDetectorInfoAction.java	0.00% <0.00%> (ø)
...c/main/java/org/opensearch/ad/util/IndexUtils.java	2.38% <ø> (ø)
...port/SearchAnomalyDetectorInfoTransportAction.java	79.54% <100.00%> (-11.37%)	⬇️

... and 3 files with indirect coverage changes

[dbwiddis]

LGTM. One question and looks like a build.gradle conflict needs resolving.

[dbwiddis]

For my own education, what are these .1 and .2? I don't see classes there. Can/should we use wildcards?

[owaiskazi19]

I went ahead and added wildcards for the rest as well.

[owaiskazi19]

Needs #876 to be merged first for build to pass.

[joshpalis]

@owaiskazi19 #876 has been merged. Seems that the build is failing for other instances of the same issue that I covered in that PR :

/home/runner/work/anomaly-detection/anomaly-detection/src/test/java/org/opensearch/ad/TestHelpers.java:1569: error: incompatible types: ImmutableOpenMap<String,IndexMetadata> cannot be converted to Map<String,IndexMetadata>
        Metadata metaData = Metadata.builder().indices(immutableOpenMap).build();
                                                       ^
/home/runner/work/anomaly-detection/anomaly-detection/src/test/java/org/opensearch/ad/transport/PreviewAnomalyDetectorTransportActionTests.java:127: error: incompatible types: ImmutableOpenMap<String,IndexMetadata> cannot be converted to Map<String,IndexMetadata>
        ClusterState clusterState = ClusterState.builder(clusterName).metadata(Metadata.builder().indices(indices).build()).build();
                                                                                                          ^
/home/runner/work/anomaly-detection/anomaly-detection/src/test/java/org/opensearch/ad/transport/IndexAnomalyDetectorTransportActionTests.java:117: error: incompatible types: ImmutableOpenMap<String,IndexMetadata> cannot be converted to Map<String,IndexMetadata>
        ClusterState clusterState = ClusterState.builder(clusterName).metadata(Metadata.builder().indices(indices).build()).build();

Simple fix is to convert the ImmutableOpenMap just to Map

[joshpalis]

LGTM other than the failing tests

[saratvemulapalli]

Thanks @owaiskazi19, changes look good to me!

[saratvemulapalli]

Not a blocker for this PR: Curious if there is a better way to get information from extensions runner.
We just dont need to pass this across the extension.

[owaiskazi19]

That's a good question. @dbwiddis /@joshpalis do you think we can add ExtensionsRunner in createComponent and inject from there?

[joshpalis]

ExtensionsRunner is already bound to guice here. I think what we need is to enable injection for rest actions so that we don't need to pass objects around in AD Extension