diff --git a/.github/workflows/unit-tests-workflow.yml b/.github/workflows/unit-tests-workflow.yml index 73e98f4a..838d9ae2 100644 --- a/.github/workflows/unit-tests-workflow.yml +++ b/.github/workflows/unit-tests-workflow.yml @@ -13,9 +13,13 @@ jobs: name: Run unit tests strategy: matrix: - os: [ubuntu-latest, macos-latest] + os: [ubuntu-latest, macos-latest, windows-latest] runs-on: ${{ matrix.os }} steps: + # Enable longer filenames for windows + - name: Enable longer filenames + if: ${{ matrix.os == 'windows-latest' }} + run: git config --system core.longpaths true - name: Checkout OpenSearch Dashboards uses: actions/checkout@v2 with: diff --git a/public/pages/DefineDetector/components/NameAndDescription/NameAndDescription.tsx b/public/pages/DefineDetector/components/NameAndDescription/NameAndDescription.tsx index 17bf1ffe..cd90e6bc 100644 --- a/public/pages/DefineDetector/components/NameAndDescription/NameAndDescription.tsx +++ b/public/pages/DefineDetector/components/NameAndDescription/NameAndDescription.tsx @@ -27,8 +27,7 @@ function NameAndDescription(props: NameAndDescriptionProps) { {({ field, form }: FieldProps) => ( <FormattedFormRow title="Name" - hint="Specify a unique and descriptive name that is easy to - recognize." + hint="Specify a unique and descriptive name that is easy to recognize." isInvalid={isInvalid(field.name, form)} error={getError(field.name, form)} helpText={`Detector name must contain 1-64 characters. Valid characters are diff --git a/public/pages/DefineDetector/components/Settings/Settings.tsx b/public/pages/DefineDetector/components/Settings/Settings.tsx index db66525f..d1e46ef7 100644 --- a/public/pages/DefineDetector/components/Settings/Settings.tsx +++ b/public/pages/DefineDetector/components/Settings/Settings.tsx @@ -37,10 +37,9 @@ export const Settings = () => { <FormattedFormRow fullWidth title="Detector interval" - hint="Define how often the detector collects data to generate - anomalies. The shorter the interval is, the more real time the - detector results will be, and the more computing resources the - detector will need." + hint={[ + `Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need.` + ]} hintLink={`${BASE_DOCS_LINK}/ad`} isInvalid={isInvalid(field.name, form)} error={getError(field.name, form)} @@ -72,8 +71,7 @@ export const Settings = () => { <FormattedFormRow fullWidth title="Window delay" - hint="Specify a window of delay for a detector to fetch data, if you - need to account for extra processing time." + hint="Specify a window of delay for a detector to fetch data, if you need to account for extra processing time." hintLink={`${BASE_DOCS_LINK}/ad`} isInvalid={isInvalid(field.name, form)} error={getError(field.name, form)} diff --git a/public/pages/DefineDetector/components/Settings/__tests__/__snapshots__/Settings.test.tsx.snap b/public/pages/DefineDetector/components/Settings/__tests__/__snapshots__/Settings.test.tsx.snap index 64ef2edb..4b370699 100644 --- a/public/pages/DefineDetector/components/Settings/__tests__/__snapshots__/Settings.test.tsx.snap +++ b/public/pages/DefineDetector/components/Settings/__tests__/__snapshots__/Settings.test.tsx.snap @@ -56,7 +56,7 @@ exports[`<Settings /> spec renders the component 1`] = ` > <div class="euiFormRow euiFormRow--fullWidth" - hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." + hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." hintlink="https://opensearch.org/docs/monitoring-plugins/ad" id="random_html_id-row" title="Detector interval" @@ -80,7 +80,7 @@ exports[`<Settings /> spec renders the component 1`] = ` class="euiText euiText--medium sublabel" style="max-width: 400px;" > - Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. + Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. <a class="euiLink euiLink--primary" diff --git a/public/pages/DefineDetector/containers/__tests__/__snapshots__/DefineDetector.test.tsx.snap b/public/pages/DefineDetector/containers/__tests__/__snapshots__/DefineDetector.test.tsx.snap index 839c07ad..0e20c363 100644 --- a/public/pages/DefineDetector/containers/__tests__/__snapshots__/DefineDetector.test.tsx.snap +++ b/public/pages/DefineDetector/containers/__tests__/__snapshots__/DefineDetector.test.tsx.snap @@ -628,7 +628,7 @@ exports[`<DefineDetector /> Full creating detector definition renders the compon > <div class="euiFormRow euiFormRow--fullWidth" - hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." + hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." hintlink="https://opensearch.org/docs/monitoring-plugins/ad" id="random_html_id-row" title="Detector interval" @@ -652,7 +652,7 @@ exports[`<DefineDetector /> Full creating detector definition renders the compon class="euiText euiText--medium sublabel" style="max-width: 400px;" > - Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. + Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. <a class="euiLink euiLink--primary" @@ -1626,7 +1626,7 @@ exports[`<DefineDetector /> empty creating detector definition renders the compo > <div class="euiFormRow euiFormRow--fullWidth" - hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." + hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." hintlink="https://opensearch.org/docs/monitoring-plugins/ad" id="random_html_id-row" title="Detector interval" @@ -1650,7 +1650,7 @@ exports[`<DefineDetector /> empty creating detector definition renders the compo class="euiText euiText--medium sublabel" style="max-width: 400px;" > - Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. + Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. <a class="euiLink euiLink--primary" @@ -2673,7 +2673,7 @@ exports[`<DefineDetector /> empty editing detector definition renders the compon > <div class="euiFormRow euiFormRow--fullWidth" - hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." + hint="Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need." hintlink="https://opensearch.org/docs/monitoring-plugins/ad" id="random_html_id-row" title="Detector interval" @@ -2697,7 +2697,7 @@ exports[`<DefineDetector /> empty editing detector definition renders the compon class="euiText euiText--medium sublabel" style="max-width: 400px;" > - Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. + Define how often the detector collects data to generate anomalies. The shorter the interval is, the more real time the detector results will be, and the more computing resources the detector will need. <a class="euiLink euiLink--primary" diff --git a/public/pages/Overview/containers/AnomalyDetectionOverview.tsx b/public/pages/Overview/containers/AnomalyDetectionOverview.tsx index 829453be..3e5bff0d 100644 --- a/public/pages/Overview/containers/AnomalyDetectionOverview.tsx +++ b/public/pages/Overview/containers/AnomalyDetectionOverview.tsx @@ -216,8 +216,7 @@ export function AnomalyDetectionOverview(props: AnomalyDetectionOverviewProps) { <CreateWorkflowStepSeparator /> <CreateWorkflowStepDetails title="2. Configure your detector" - content="Choose the fields in your index that you want to check for anomalies. - You may also set a category field to see a granular view of anomalies within each entity." + content="Choose the fields in your index that you want to check for anomalies. You may also set a category field to see a granular view of anomalies within each entity." /> <CreateWorkflowStepSeparator /> <CreateWorkflowStepDetails