Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Ensure Alerting CI is running ktlint #573

Closed
peterzhuamazon opened this issue Sep 27, 2022 · 2 comments
Closed

[BUG] Ensure Alerting CI is running ktlint #573

peterzhuamazon opened this issue Sep 27, 2022 · 2 comments
Assignees
@sbcd90
Labels
bug Something isn't working windows

Comments

@peterzhuamazon
Copy link
Member

[BUG] Ensure Alerting CI is running ktlint.

Upgrade ktlint to 0.47.0 to resolve max-length issues on Windows and LINUX (rare)
pinterest/ktlint#1496 (comment)
#557 (comment)

As of now we have disabled ktlint on both the assemble and publishingzips task to avoid error.

Thanks.
@peterzhuamazon peterzhuamazon added bug Something isn't working windows labels Sep 27, 2022
This was referenced Sep 29, 2022
Closed
Closed
@dblock
Copy link
Member

dblock commented Sep 29, 2022

We should be doing this as part of #214

@sbcd90 sbcd90 mentioned this issue Oct 3, 2022
Merged
@praveensameneni
Copy link
Member

Closing the issue as the code has been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbcd90 sbcd90

Labels
bug Something isn't working windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dblock @sbcd90 @praveensameneni @peterzhuamazon