Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flaky tests in SecureWorkflowRestApiIT #1246

Closed
AWSHurneyt opened this issue Oct 10, 2023 · 1 comment
Closed

[BUG] Flaky tests in SecureWorkflowRestApiIT #1246

AWSHurneyt opened this issue Oct 10, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AWSHurneyt
Copy link
Collaborator

What is the bug?
This PR calls out that he tests in SecureWorkflowRestApiIT are flaky when executed in the Jenkins CI. The flakiness will need to be investigated and resolved.
#1166

The @Ignore annotation was causing the integ tests to fail with the following error. This PR changes the annotation to the recommended @AwaitsFix.
#1245

> Task :alerting:forbiddenApisTest FAILED
Forbidden annotation use: org.junit.Ignore [Use AwaitsFix instead]
  in org.opensearch.alerting.resthandler.SecureWorkflowRestApiIT (SecureWorkflowRestApiIT.kt, annotation on class declaration)
Scanned 120 class file(s) for forbidden API invocations (in 0.38s), 1 error(s).

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':alerting:forbiddenApisTest'.
> de.thetaphi.forbiddenapis.ForbiddenApiException: Check for forbidden API calls failed, see log.
@AWSHurneyt AWSHurneyt added bug Something isn't working untriaged labels Oct 10, 2023
@riysaxen-amzn
Copy link
Collaborator

closing in favor of #1245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants