[BUG] The spotless should take care of unified imports ordering (all other subprojects) #9399
Conversation
…other subprojects) Signed-off-by: Andriy Redko <[email protected]>
reta
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
gbbafna,
setiah,
kartg,
kotwanikunal,
mch2,
nknize,
owaiskazi19,
Rishikesh1159,
ryanbogan,
saratvemulapalli,
shwetathareja,
dreamer-89,
tlfeng,
VachaShah,
dbwiddis,
sachinpkale and
sohami
as code owners
reta
changed the title
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #9399 +/- ##
============================================
- Coverage 71.20% 71.13% -0.08%
+ Complexity 57529 57471 -58
============================================
Files 4777 4777
Lines 270822 270822
Branches 39586 39586
============================================
- Hits 192833 192639 -194
- Misses 61808 62001 +193
- Partials 16181 16182 +1
|
Compatibility status:Checks if related components are compatible with change 9ce008d Incompatible componentsIncompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/asynchronous-search.git] Skipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git] |
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-9399-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7ffcd6500e0bd5956cef5c289ee66d9f99d533fc
# Push it to GitHub
git push --set-upstream origin backport/backport-9399-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.xThen, create a pull request where the |
|
@reta I was praying for the backport to work. But 304 files was too optimistic 😉 |
🙏 thanks @kotwanikunal , will do manually right after #9398 |
…other subprojects) (opensearch-project#9399) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 7ffcd65)
…other subprojects) (#9399) (#9404) Signed-off-by: Andriy Redko <[email protected]> (cherry picked from commit 7ffcd65)
…other subprojects) (opensearch-project#9399) Signed-off-by: Andriy Redko <[email protected]>
…other subprojects) (opensearch-project#9399) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kiran Reddy <[email protected]>
…other subprojects) (opensearch-project#9399) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Kaushal Kumar <[email protected]>
…other subprojects) (opensearch-project#9399) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Ivan Brusic <[email protected]>
…other subprojects) (opensearch-project#9399) Signed-off-by: Andriy Redko <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
Description
Came out of #9082 (review), the spotless does not enforce any formatting on order of imports statements, as such those are very chaotic in the codebase.
Related Issues
Closes #9306
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.