Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run compatibility check based on PR base branch #9374

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Run compatibility check based on PR base branch #9374

merged 4 commits into from
Aug 23, 2023

Conversation

gaiksaya
Copy link
Member

Description

Run compatibility check based on PR base branch rather than main branch. See pull_request_target and pull_request

Related Issues

Resolves #9371

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaiksaya gaiksaya mentioned this pull request Aug 15, 2023
Merged
6 tasks
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 152321b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled

@codecov
Copy link

codecov bot commented Aug 15, 2023 •
edited
Loading

Codecov Report

Merging #9374 (d62b95b) into main (ebdffbb) will decrease coverage by 0.05%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #9374      +/-   ##
============================================
- Coverage     71.20%   71.15%   -0.05%     
+ Complexity    57474    57462      -12     
============================================
  Files          4776     4776              
  Lines        270815   270815              
  Branches      39584    39584              
============================================
- Hits         192835   192705     -130     
- Misses        61741    61948     +207     
+ Partials      16239    16162      -77

see 467 files with indirect coverage changes

peternied
peternied requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use and read encrypted secrets in a workflow file if you have access to edit the file.

https://docs.github.com/en/actions/security-guides/encrypted-secrets#accessing-your-secrets

When triggered by pull_request write permissions are not allowed so app_id and other secrets won't be resolved

@peternied
Copy link
Member

@gaiksaya Any progress here?

@gaiksaya
Copy link
Member Author

@gaiksaya Any progress here?

Sorry for the delay. Updated the PR with the changes. Here is sample comment: gaiksaya#8

@gaiksaya
Remove test env
4b3b160 
Signed-off-by: Sayali Gaikawad <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

peternied
peternied approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 60d272b

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@gaiksaya
Create another job to comment
20378a7 
Signed-off-by: Sayali Gaikawad <[email protected]>
@gaiksaya
Fix naming
d62b95b 
Signed-off-by: Sayali Gaikawad <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.classMethod
      1 org.opensearch.common.util.concurrent.QueueResizableOpenSearchThreadPoolExecutorTests.testResizeQueueDown

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 980bf3c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

@gaiksaya gaiksaya merged commit b8fe8b2 into opensearch-project:main Aug 23, 2023
@gaiksaya gaiksaya deleted the fix-workflow branch August 23, 2023 20:15
@gaiksaya gaiksaya added the backport 2.x Backport to 2.x branch label Aug 23, 2023
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 23, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2023
@github-actions
Run compatibility check based on PR base branch (#9374)
aca8a71 
Signed-off-by: Sayali Gaikawad <[email protected]>
(cherry picked from commit b8fe8b2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
neetikasinghal pushed a commit to neetikasinghal/OpenSearch that referenced this pull request Aug 23, 2023
@gaiksaya @neetikasinghal
Run compatibility check based on PR base branch (opensearch-project#9374
d6ff50b 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
kotwanikunal pushed a commit that referenced this pull request Aug 23, 2023
@opensearch-trigger-bot @github-actions
Run compatibility check based on PR base branch (#9374) (#9521)
7420070 
(cherry picked from commit b8fe8b2)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Aug 25, 2023
@gaiksaya @austintlee
Run compatibility check based on PR base branch (opensearch-project#9374
1401223 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
@gaiksaya
Run compatibility check based on PR base branch (opensearch-project#9374
0ea97d7 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
Gaganjuneja pushed a commit to Gaganjuneja/OpenSearch that referenced this pull request Aug 28, 2023
@gaiksaya
Run compatibility check based on PR base branch (opensearch-project#9374
580ad59 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Gagan Juneja <[email protected]>
kkmr pushed a commit to kkmr/OpenSearch that referenced this pull request Aug 28, 2023
@gaiksaya @kkmr
Run compatibility check based on PR base branch (opensearch-project#9374
1aa6176 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Kiran Reddy <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
@gaiksaya @kaushalmahi12
Run compatibility check based on PR base branch (opensearch-project#9374
675f6cf 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Kaushal Kumar <[email protected]>
@peternied peternied mentioned this pull request Sep 12, 2023
Merged
6 tasks
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
@gaiksaya @brusic
Run compatibility check based on PR base branch (opensearch-project#9374
827cae6 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Ivan Brusic <[email protected]>
@peternied peternied mentioned this pull request Nov 30, 2023
Closed
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@gaiksaya @shiv0408
Run compatibility check based on PR base branch (opensearch-project#9374
eb4bdfe 
)

Signed-off-by: Sayali Gaikawad <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kotwanikunal kotwanikunal kotwanikunal approved these changes

@peternied peternied peternied approved these changes

@reta reta Awaiting requested review from reta

@anasalkouz anasalkouz Awaiting requested review from anasalkouz

@andrross andrross Awaiting requested review from andrross

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE

@dblock dblock Awaiting requested review from dblock

@gbbafna gbbafna Awaiting requested review from gbbafna

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@mch2 mch2 Awaiting requested review from mch2

@nknize nknize Awaiting requested review from nknize

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli

@shwetathareja shwetathareja Awaiting requested review from shwetathareja

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah

@dbwiddis dbwiddis Awaiting requested review from dbwiddis

@sachinpkale sachinpkale Awaiting requested review from sachinpkale

@sohami sohami Awaiting requested review from sohami

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Check compatibility doesn't run on the code in the pull request
3 participants
@gaiksaya @peternied @kotwanikunal