Introduce new setting search.concurrent.max_slice to control the slice computation for concurrent segment search #8884

sohami · 2023-07-26T01:12:08Z

Description

Introduces a static setting in 2.x to control slice computation using lucene default or max target slice mechanism for concurrent segment search. This is replacement of PR #8847

Related Issues

Resolves #7358

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2023-07-26T02:02:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

URL: https://build.ci.opensearch.org/job/gradle-check/20948/
CommitID: fd15f47
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2023-07-26T02:03:30Z

Codecov Report

Merging #8884 (a63eb0d) into 2.x (5164fe2) will increase coverage by 0.22%.
The diff coverage is 87.09%.

@@             Coverage Diff              @@
##                2.x    #8884      +/-   ##
============================================
+ Coverage     70.64%   70.87%   +0.22%     
- Complexity    57265    57400     +135     
============================================
  Files          4745     4747       +2     
  Lines        271070   271099      +29     
  Branches      39984    39986       +2     
============================================
+ Hits         191508   192132     +624     
+ Misses        63130    62476     -654     
- Partials      16432    16491      +59

Files Changed	Coverage Δ
...org/opensearch/search/SearchBootstrapSettings.java	`62.50% <62.50%> (ø)`
...search/search/internal/MaxTargetSliceSupplier.java	`92.30% <92.30%> (ø)`
...rg/opensearch/common/settings/ClusterSettings.java	`93.18% <100.00%> (ø)`
server/src/main/java/org/opensearch/node/Node.java	`86.06% <100.00%> (+0.01%)`	⬆️
...ensearch/search/internal/ContextIndexSearcher.java	`66.10% <100.00%> (+1.39%)`	⬆️

... and 464 files with indirect coverage changes

github-actions · 2023-07-26T02:07:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      3 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString

URL: https://build.ci.opensearch.org/job/gradle-check/20949/
CommitID: 6a6431b
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-07-26T02:08:13Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessAfterFailureInFirstAttemptAfterSnapshotAndMetadataUpload

URL: https://build.ci.opensearch.org/job/gradle-check/20950/
CommitID: 44940e0
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

sohami · 2023-07-26T15:23:53Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕

TEST FAILURES:
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
      1 org.opensearch.indices.replication.SegmentReplicationTargetServiceTests.testShardAlreadyReplicating
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshSuccessAfterFailureInFirstAttemptAfterSnapshotAndMetadataUpload
URL: https://build.ci.opensearch.org/job/gradle-check/20950/

CommitID: 44940e0
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

unrelated test failures

sohami · 2023-07-27T01:35:54Z

We would also need to have a documentation update for this new setting, could you please create an issue at https://github.com/opensearch-project/documentation-website, thank you.

@reta Concurrent search is an experimental feature currently so I was planning to track this as part of documentation with GA. Don't think we will need to document it now as it cannot be used standalone without enabling the feature

sohami · 2023-07-27T01:49:14Z

@reta Have addressed other review comments. Thanks!

github-actions · 2023-07-27T02:11:12Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21038/
CommitID: c58eb62
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-07-27T05:42:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21055/
CommitID: c58eb62
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

sohami · 2023-07-27T05:44:34Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌

URL: https://build.ci.opensearch.org/job/gradle-check/21055/

CommitID: c58eb62
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

known flaky tests #6090

reta · 2023-07-27T12:10:56Z

@reta Concurrent search is an experimental feature currently so I was planning to track this as part of documentation with GA

Sure, your pick (documenting experimental features like that would let people to try them out before GA, possibility filing bugs and issues)

server/src/main/java/org/opensearch/search/SearchBootstrapSettings.java

reta · 2023-07-27T12:12:36Z

@reta Have addressed other review comments. Thanks!

Thanks @sohami , one small comment (missed that but you pointed that out) but LGTM otherwise

sohami · 2023-07-27T17:33:25Z

@reta Have addressed other review comments. Thanks!

Thanks @sohami , one small comment (missed that but you pointed that out) but LGTM otherwise

@reta updated and rebased.

github-actions · 2023-07-27T17:41:01Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21110/
CommitID: 75a553b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

sohami · 2023-07-27T17:56:19Z

@reta Have addressed other review comments. Thanks!

Thanks @sohami , one small comment (missed that but you pointed that out) but LGTM otherwise

@reta updated and rebased.

oops there are some test failures with latest changes. looking into it

test/framework/src/main/java/org/opensearch/test/OpenSearchSingleNodeTestCase.java

github-actions · 2023-07-27T19:10:52Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❕
TEST FAILURES:

      1 org.opensearch.search.aggregations.bucket.DateRangeIT.classMethod
      1 org.opensearch.search.aggregations.bucket.DateHistogramOffsetIT.classMethod
      1 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.action.bulk.BulkProcessorIT.testBulkProcessorConcurrentRequestsReadOnlyIndex

URL: https://build.ci.opensearch.org/job/gradle-check/21122/
CommitID: c1cbd7c
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

github-actions · 2023-07-27T21:50:29Z

Gradle Check (Jenkins) Run Completed with:

RESULT: ❌
URL: https://build.ci.opensearch.org/job/gradle-check/21134/
CommitID: c1cbd7c
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

reta · 2023-07-27T22:22:14Z

Still needs some adjustments, failing tests

…e computation for concurrent segment search. It uses lucene default mechanism if the setting value is <=0 otherwise uses custom max target slice mechanism Signed-off-by: Sorabh Hamirwasia <[email protected]>

Signed-off-by: Sorabh Hamirwasia <[email protected]>

github-actions · 2023-07-28T02:32:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/21206/
CommitID: a63eb0d

sohami · 2023-07-28T04:28:48Z

Still needs some adjustments, failing tests

fixed now.

test/framework/src/main/java/org/opensearch/test/OpenSearchSingleNodeTestCase.java

reta · 2023-07-28T12:47:26Z

@andrross since you have neen looking into this change for main, any concerns / comments? thank you.

sohami requested review from reta, anasalkouz, andrross, Bukhtawar, CEHENKLE, dblock, gbbafna, setiah, kartg, kotwanikunal, mch2, nknize, owaiskazi19, Rishikesh1159, ryanbogan, saratvemulapalli, shwetathareja, dreamer-89, tlfeng, VachaShah, dbwiddis and sachinpkale as code owners July 26, 2023 01:12

sohami force-pushed the issue-7358-2x branch from fd15f47 to 6a6431b Compare July 26, 2023 01:13

sohami mentioned this pull request Jul 26, 2023

Introduce new setting search.concurrent.max_slice to control the slice computation for concurrent segment search #8847

Closed

6 tasks

sohami force-pushed the issue-7358-2x branch from 6a6431b to 44940e0 Compare July 26, 2023 01:16

sohami force-pushed the issue-7358-2x branch from 44940e0 to c58eb62 Compare July 27, 2023 01:48

reta reviewed Jul 27, 2023

View reviewed changes

server/src/main/java/org/opensearch/search/SearchBootstrapSettings.java Show resolved Hide resolved

sohami force-pushed the issue-7358-2x branch from c58eb62 to 75a553b Compare July 27, 2023 17:30

sohami force-pushed the issue-7358-2x branch from 75a553b to c1cbd7c Compare July 27, 2023 18:21

reta reviewed Jul 27, 2023

View reviewed changes

test/framework/src/main/java/org/opensearch/test/OpenSearchSingleNodeTestCase.java Outdated Show resolved Hide resolved

sohami added 3 commits July 27, 2023 18:18

Introduce new setting search.concurrent.max_slice to control the slic…

cf80c66

…e computation for concurrent segment search. It uses lucene default mechanism if the setting value is <=0 otherwise uses custom max target slice mechanism Signed-off-by: Sorabh Hamirwasia <[email protected]>

Address review comments

fd7fcf3

Signed-off-by: Sorabh Hamirwasia <[email protected]>

Address review comments

a63eb0d

Signed-off-by: Sorabh Hamirwasia <[email protected]>

sohami force-pushed the issue-7358-2x branch from c1cbd7c to a63eb0d Compare July 28, 2023 01:50

reta reviewed Jul 28, 2023

View reviewed changes

test/framework/src/main/java/org/opensearch/test/OpenSearchSingleNodeTestCase.java Show resolved Hide resolved

reta approved these changes Jul 28, 2023

View reviewed changes

andrross approved these changes Jul 28, 2023

View reviewed changes

andrross merged commit ea83f8e into opensearch-project:2.x Jul 28, 2023

jed326 mentioned this pull request Aug 14, 2023

[Concurrent Segment Search] Change ConcurrentSearchTasksIT to use custom slice count #9317

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce new setting search.concurrent.max_slice to control the slice computation for concurrent segment search #8884

Introduce new setting search.concurrent.max_slice to control the slice computation for concurrent segment search #8884

sohami commented Jul 26, 2023

github-actions bot commented Jul 26, 2023

codecov bot commented Jul 26, 2023 •

edited

Loading

github-actions bot commented Jul 26, 2023

github-actions bot commented Jul 26, 2023

sohami commented Jul 26, 2023

Gradle Check (Jenkins) Run Completed with:

sohami commented Jul 27, 2023

sohami commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

sohami commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Jul 27, 2023

reta commented Jul 27, 2023

sohami commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

sohami commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

reta commented Jul 27, 2023

github-actions bot commented Jul 28, 2023

sohami commented Jul 28, 2023

reta commented Jul 28, 2023

Introduce new setting search.concurrent.max_slice to control the slice computation for concurrent segment search #8884

Introduce new setting search.concurrent.max_slice to control the slice computation for concurrent segment search #8884

Conversation

sohami commented Jul 26, 2023

Description

Related Issues

Check List

github-actions bot commented Jul 26, 2023

Gradle Check (Jenkins) Run Completed with:

codecov bot commented Jul 26, 2023 • edited Loading

Codecov Report

github-actions bot commented Jul 26, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 26, 2023

Gradle Check (Jenkins) Run Completed with:

sohami commented Jul 26, 2023

Gradle Check (Jenkins) Run Completed with:

sohami commented Jul 27, 2023

sohami commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

sohami commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Jul 27, 2023

reta commented Jul 27, 2023

sohami commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

sohami commented Jul 27, 2023

github-actions bot commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jul 27, 2023

Gradle Check (Jenkins) Run Completed with:

reta commented Jul 27, 2023

github-actions bot commented Jul 28, 2023

Gradle Check (Jenkins) Run Completed with:

sohami commented Jul 28, 2023

reta commented Jul 28, 2023

codecov bot commented Jul 26, 2023 •

edited

Loading