[NOCOMMIT] Revert "Flat object field should delegate to keyword field…

[msfroh]

… for most query types (#14383)"

This reverts commit 9ddee61.

Trying to identify the source of a benchmark regression for big5 keyword-in-range query.

I don't think this commit caused it, but it's the only commit I found related to keyword fields or range queries around October 11-15, and I'd like to do some benchmarks.

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[msfroh]

{"run-benchmark-test": "id_5"}

[github-actions]

The Jenkins job url is https://build.ci.opensearch.org/job/benchmark-pull-request/1539/ . Final results will be published once the job is completed.

[msfroh]

Talked with @rishabh6788, and it sounds like the regression we're seeing in the nightly benchmarks is only on on ARM processors, not x86. That makes it even less likely that it's tied to a specific code change (versus e.g a JDK or other dependency upgrade).

[github-actions]

✅ Gradle check result for 5f5317d: SUCCESS

[codecov]

Codecov Report

Attention: Patch coverage is 51.02041% with 48 lines in your changes missing coverage. Please review.

Project coverage is 71.98%. Comparing base (72559bf) to head (5f5317d).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
...opensearch/index/mapper/FlatObjectFieldMapper.java	48.75%	33 Missing and 8 partials ⚠️
...rg/opensearch/index/mapper/KeywordFieldMapper.java	61.11%	3 Missing and 4 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #16515      +/-   ##
============================================
- Coverage     72.11%   71.98%   -0.13%     
+ Complexity    65071    65047      -24     
============================================
  Files          5313     5313              
  Lines        303413   303450      +37     
  Branches      43906    43914       +8     
============================================
- Hits         218816   218452     -364     
- Misses        66639    67119     +480     
+ Partials      17958    17879      -79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[msfroh]

@rishabh6788 found that the benchmark regression was related to the Lucene 9.12 upgrade.