Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support of copying remote directory without specifying whether … #13666

Closed
wants to merge 1 commit into from
Closed

Added support of copying remote directory without specifying whether … #13666

wants to merge 1 commit into from

Conversation

vikasvb90
Copy link
Contributor

@vikasvb90 vikasvb90 commented May 14, 2024 •
edited by reta
Loading

Description

Fixes invalid red flag raised by #13663

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9aa2458: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented May 14, 2024

❌ Gradle check result for 9aa2458: FAILURE

#13667

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9aa2458: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vikasvb90
Copy link
Contributor Author

Flaky test failure

> Task :server:test

Tests with failures:
 - org.opensearch.search.query.QueryPhaseTests.testQueryTimeoutChecker {p0=0 p1=org.opensearch.search.query.QueryPhase$DefaultQueryPhaseSearcher@652e345}

12999 tests completed, 1 failed, 37 skipped

#9464

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 9aa2458: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@vikasvb90 @reta
Added support of copying remote directory without specifying whether …
2d74206 
…its a low priority upload

Signed-off-by: vikasvb90 <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
@reta reta force-pushed the remote_dir_copy_without_specifying_low_priority branch from 9aa2458 to 2d74206 Compare May 14, 2024 18:42
@reta
Copy link
Collaborator

reta commented May 14, 2024

❌ Gradle check result for 9aa2458: FAILURE

#13046

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2d74206: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented May 14, 2024

❌ Gradle check result for 2d74206: FAILURE

#13473
#11997

@reta
Copy link
Collaborator

reta commented May 14, 2024 •
edited
Loading

@vikasvb90 we cannot get this pull request passing all the checks, the change was reverted (#13663), please resubmit the proper backport, thank you

@reta reta closed this May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 2d74206: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vikasvb90 @reta