-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TermsQueryBuilderTests to include TermQuery #13517
Conversation
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13517 +/- ##
===========================================
Coverage 71.42% 71.42%
- Complexity 59978 60973 +995
===========================================
Files 4985 5050 +65
Lines 282275 286865 +4590
Branches 40946 41571 +625
===========================================
+ Hits 201603 204906 +3303
- Misses 63999 65007 +1008
- Partials 16673 16952 +279 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13517-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37df569367c5f57ee80785dbd446bd7ed7e49faa
# Push it to GitHub
git push --set-upstream origin backport/backport-13517-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
@harshavamsi this needs a manual backport. |
…t#13517) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 37df569)
Signed-off-by: Harsha Vamsi Kalluri <[email protected]> (cherry picked from commit 37df569) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 37df569) Signed-off-by: Harsha Vamsi Kalluri <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…t#13517) Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
…t#13517) Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
…t#13517) Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Description
Quick follow up for #13480
Related Issues
Resolves #13480
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.