Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TermsQueryBuilderTests to include TermQuery #13517

Merged
merged 1 commit into from
May 2, 2024

Conversation

harshavamsi
Copy link
Contributor

@harshavamsi harshavamsi commented May 2, 2024

Description

Quick follow up for #13480

Related Issues

Resolves #13480

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@harshavamsi harshavamsi added skip-changelog backport 2.x Backport to 2.x branch labels May 2, 2024
@github-actions github-actions bot added bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. Search Search query, autocomplete ...etc labels May 2, 2024
Copy link
Contributor

github-actions bot commented May 2, 2024

✅ Gradle check result for 22ca17c: SUCCESS

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.42%. Comparing base (b15cb0c) to head (22ca17c).
Report is 256 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##               main   #13517     +/-   ##
===========================================
  Coverage     71.42%   71.42%             
- Complexity    59978    60973    +995     
===========================================
  Files          4985     5050     +65     
  Lines        282275   286865   +4590     
  Branches      40946    41571    +625     
===========================================
+ Hits         201603   204906   +3303     
- Misses        63999    65007   +1008     
- Partials      16673    16952    +279     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@VachaShah VachaShah merged commit 37df569 into opensearch-project:main May 2, 2024
56 of 80 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-13517-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37df569367c5f57ee80785dbd446bd7ed7e49faa
# Push it to GitHub
git push --set-upstream origin backport/backport-13517-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-13517-to-2.x.

@VachaShah
Copy link
Collaborator

@harshavamsi this needs a manual backport.

harshavamsi added a commit to harshavamsi/OpenSearch that referenced this pull request May 2, 2024
@harshavamsi harshavamsi added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch backport-failed labels May 2, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 2, 2024
Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
(cherry picked from commit 37df569)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
VachaShah pushed a commit that referenced this pull request May 3, 2024
(cherry picked from commit 37df569)

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
finnegancarroll pushed a commit to finnegancarroll/OpenSearch that referenced this pull request May 10, 2024
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request May 17, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. Search Search query, autocomplete ...etc skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] org.opensearch.index.query.TermsQueryBuilderTests.testToQuery is flaky
2 participants