Enhance changelog workflow to check for missing labels #13167
Conversation
Compatibility status:Checks if related components are compatible with change 1212672 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13167 +/- ##
============================================
+ Coverage 71.42% 71.47% +0.05%
- Complexity 59978 60638 +660
============================================
Files 4985 5039 +54
Lines 282275 285338 +3063
Branches 40946 41327 +381
============================================
+ Hits 201603 203940 +2337
- Misses 63999 64557 +558
- Partials 16673 16841 +168 ☔ View full report in Codecov by Sentry. |
|
@kotwanikunal Can you link to example workflows of this change that show the new error states in your fork? |
|
This workflow is failing in this PR, that's not expected, is it? It should have re-run it when skip-changelog was added and skipped it? |
kotwanikunal
force-pushed
the
changelog-verifier-updates
branch
from
d05225e to
6b18aa1
Compare
There was a scenario that was missing. Updated the workflow
Sure. Without backport label- kotwanikunal#164 |
|
❌ Gradle check result for 6b18aa1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
None of these failed, what should the expected behavior be? |
|
❌ Gradle check result for 6b18aa1: ABORTED Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 6b18aa1: ABORTED Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@peternied Looks like a GH bug. Recreated the PR without any changes: kotwanikunal#167 |
|
❌ Gradle check result for 6b18aa1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Looks like I need to rebase. Complaining of a version mismatch |
Signed-off-by: Kunal Kotwani <[email protected]>
kotwanikunal
force-pushed
the
changelog-verifier-updates
branch
from
6b18aa1 to
1212672
Compare
|
❌ Gradle check result for 1212672: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@kotwanikunal What is the root cause on the gradle check failures? |
|
I was missing a rebase previous - a new change got merged to |
Description
CHANGELOG.mdfile and ensures a backport label exists if the entry is BwCRelated Issues
N/A
Check List
New functionality includes testing.All tests passNew functionality has been documented.New functionality has javadoc addedFailing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)Commit changes are listed out in CHANGELOG.md file (See: Changelog)Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.