Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Shard id awareness of SearchLookup (#1063) #12436

Merged

Conversation

andrross
Copy link
Member

Backports 87ac374 from main from #1063

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@andrross andrross changed the title Shard id awareness of SearchLookup (#1063) [Backport 2.x] Shard id awareness of SearchLookup (#1063) Feb 22, 2024
Copy link
Contributor

github-actions bot commented Feb 22, 2024

Compatibility status:

Checks if related components are compatible with change f5197ad

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 901bf9f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member Author

❌ Gradle check result for 901bf9f: FAILURE

#10704

* Shard id awareness of SearchLookup

Signed-off-by: Alexander Koval <[email protected]>

* Add unit test for deprecated constructor

Signed-off-by: Andrew Ross <[email protected]>

---------

Signed-off-by: Alexander Koval <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
Co-authored-by: Andrew Ross <[email protected]>
(cherry picked from commit 87ac374)
@andrross andrross force-pushed the backport/backport-1063-to-2.x branch from 901bf9f to f5197ad Compare February 23, 2024 20:48
Copy link
Contributor

❌ Gradle check result for f5197ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for f5197ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for f5197ad: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.21%. Comparing base (44f1417) to head (f5197ad).
Report is 4 commits behind head on 2.x.

Files Patch % Lines
.../org/opensearch/index/query/QueryShardContext.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12436      +/-   ##
============================================
+ Coverage     71.08%   71.21%   +0.13%     
- Complexity    59953    59985      +32     
============================================
  Files          4945     4945              
  Lines        282230   282332     +102     
  Branches      41341    41365      +24     
============================================
+ Hits         200626   201072     +446     
+ Misses        64630    64215     -415     
- Partials      16974    17045      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotwanikunal kotwanikunal merged commit bb2106f into opensearch-project:2.x Feb 27, 2024
29 checks passed
@andrross andrross deleted the backport/backport-1063-to-2.x branch May 7, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants