Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix error in RemoteSegmentStoreDirectory when debug logging is enabled (#12328) #12347

Merged

Conversation

peternied
Copy link
Member

Description

Backport 006ba0e from #12328.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…gging is enabled (opensearch-project#12328)

Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 006ba0e)
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change e93055a

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

✅ Gradle check result for e93055a: SUCCESS

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f0eb433) 71.18% compared to head (e93055a) 71.16%.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12347      +/-   ##
============================================
- Coverage     71.18%   71.16%   -0.03%     
+ Complexity    59996    59939      -57     
============================================
  Files          4944     4944              
  Lines        282203   282203              
  Branches      41335    41335              
============================================
- Hits         200899   200822      -77     
- Misses        64276    64372      +96     
+ Partials      17028    17009      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peternied
Copy link
Member Author

@andrross Mind taking a look?

@peternied peternied merged commit b7f8278 into opensearch-project:2.x Feb 16, 2024
78 of 79 checks passed
@peternied peternied deleted the backport/backport-12328-to-2.x branch February 16, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants