Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Enable test suites to run with segrep #12307

Merged

Conversation

Poojita-Raj
Copy link
Contributor

Description

Identified some of the test modules that are critical to segment replication and enabling them to run with segrep enabled.

indexing
ingest
recovery

Related Issues

Resolves #11804

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Feb 13, 2024

Compatibility status:

Checks if related components are compatible with change df20af9

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❕ Gradle check result for 19c2fac: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bff8eb7) 71.49% compared to head (df20af9) 71.34%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12307      +/-   ##
============================================
- Coverage     71.49%   71.34%   -0.16%     
+ Complexity    59859    59779      -80     
============================================
  Files          4959     4959              
  Lines        281129   281129              
  Branches      40857    40857              
============================================
- Hits         201003   200566     -437     
- Misses        63425    63912     +487     
+ Partials      16701    16651      -50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❕ Gradle check result for df20af9: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@Poojita-Raj
Copy link
Contributor Author

❕ Gradle check result for 19c2fac: UNSTABLE

* **TEST FAILURES:**
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

#9191

@Rishikesh1159 Rishikesh1159 added the backport 2.x Backport to 2.x branch label Feb 17, 2024
@Rishikesh1159 Rishikesh1159 merged commit 181b985 into opensearch-project:main Feb 17, 2024
33 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 17, 2024
* Enable test suites to run with segrep

Signed-off-by: Poojita Raj <[email protected]>

* Refactor static settings into ParameterizedStaticSettingsOpenSearchIntegTestCase

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit 181b985)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159 pushed a commit that referenced this pull request Feb 29, 2024
* Enable test suites to run with segrep

Signed-off-by: Poojita Raj <[email protected]>

* Refactor static settings into ParameterizedStaticSettingsOpenSearchIntegTestCase

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
(cherry picked from commit 181b985)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Rishikesh1159 pushed a commit that referenced this pull request Feb 29, 2024
…12354)

* Enable test suites to run with segrep



* Refactor static settings into ParameterizedStaticSettingsOpenSearchIntegTestCase



---------


(cherry picked from commit 181b985)

Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
…ch-project#12307)

* Enable test suites to run with segrep

Signed-off-by: Poojita Raj <[email protected]>

* Refactor static settings into ParameterizedStaticSettingsOpenSearchIntegTestCase

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…ch-project#12307)

* Enable test suites to run with segrep

Signed-off-by: Poojita Raj <[email protected]>

* Refactor static settings into ParameterizedStaticSettingsOpenSearchIntegTestCase

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ch-project#12307)

* Enable test suites to run with segrep

Signed-off-by: Poojita Raj <[email protected]>

* Refactor static settings into ParameterizedStaticSettingsOpenSearchIntegTestCase

Signed-off-by: Poojita Raj <[email protected]>

---------

Signed-off-by: Poojita Raj <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Segment Replication] Identify/List out all Integ Tests that must be ran with segment replication enabled
4 participants