Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for flaky tests in weighted routing #10955

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

anshu1106
Copy link
Contributor

@anshu1106 anshu1106 commented Oct 27, 2023

Description

Fixes flaky tests
#5957
#10673

Related Issues

Resolves #5957 #10673

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2023

Compatibility status:

Checks if related components are compatible with change 8602445

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: Anshu Agarwal <[email protected]>
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.classMethod

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #10955 (8602445) into main (0c9fc21) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main   #10955      +/-   ##
============================================
+ Coverage     71.23%   71.26%   +0.02%     
- Complexity    58730    58793      +63     
============================================
  Files          4872     4872              
  Lines        276707   276707              
  Branches      40222    40222              
============================================
+ Hits         197124   197183      +59     
+ Misses        63115    63100      -15     
+ Partials      16468    16424      -44     

see 495 files with indirect coverage changes

@anshu1106 anshu1106 self-assigned this Oct 30, 2023
@github-actions github-actions bot added bug Something isn't working distributed framework flaky-test Random test failure that succeeds on second run labels Oct 30, 2023
@kotwanikunal kotwanikunal added the backport 2.x Backport to 2.x branch label Oct 31, 2023
@kotwanikunal kotwanikunal merged commit cb39d00 into opensearch-project:main Oct 31, 2023
33 of 38 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 31, 2023
Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
(cherry picked from commit cb39d00)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Nov 3, 2023
(cherry picked from commit cb39d00)

Signed-off-by: Anshu Agarwal <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Signed-off-by: Anshu Agarwal <[email protected]>
Co-authored-by: Anshu Agarwal <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch bug Something isn't working distributed framework flaky-test Random test failure that succeeds on second run skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SearchWeightedRoutingIT.testSearchAggregationWithNetworkDisruption_FailOpenEnabled is flaky
4 participants