Restore ClusterState version during remote state restore

[linuxpi]

Description

• During QL remote state restore we do not restore previous cluster state version
• With this change, we intent to restore the cluster state version back.

Related Issues

Resolves #10692

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)
• Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change b39b696

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/28810/
• CommitID: dd2a41a

[codecov]

Codecov Report

Merging #10853 (b39b696) into main (0c9fc21) will decrease coverage by 0.08%.
Report is 1 commits behind head on main.
The diff coverage is 30.76%.

@@             Coverage Diff              @@
##               main   #10853      +/-   ##
============================================
- Coverage     71.23%   71.16%   -0.08%     
+ Complexity    58730    58695      -35     
============================================
  Files          4872     4872              
  Lines        276707   276712       +5     
  Branches      40222    40222              
============================================
- Hits         197124   196923     -201     
- Misses        63115    63377     +262     
+ Partials      16468    16412      -56     

Files	Coverage Δ
...arch/gateway/remote/RemoteClusterStateService.java	72.70% <80.00%> (+0.55%)	⬆️
...arch/index/recovery/RemoteStoreRestoreService.java	12.59% <0.00%> (-0.21%)	⬇️

... and 501 files with indirect coverage changes

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

• URL: https://build.ci.opensearch.org/job/gradle-check/28887/
• CommitID: 1730b9d
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/28944/
• CommitID: 978a073

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28945/
• CommitID: c530d2e
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28948/
• CommitID: d2d97bf
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[linuxpi]

Flaky Test

org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob #6090
org.opensearch.cluster.service.MasterServiceTests.testClusterStateBatchedUpdates #10899

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28971/
• CommitID: ca4e51f
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/28977/
• CommitID: 6028a28
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[BhumikaSaini-Amazon]

Do we need to add assertions to the existing tests to validate that the ClusterState version is indeed restored?

[linuxpi]

Do we need to add assertions to the existing tests to validate that the ClusterState version is indeed restored?

We have added assertions to validate new cluster state version would always be greater than previous version

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/29128/
• CommitID: 5e40fbc
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: UNSTABLE ❕
• TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreStatsIT.testDownloadStatsCorrectnessSinglePrimarySingleReplica

• URL: https://build.ci.opensearch.org/job/gradle-check/29129/
• CommitID: b39b696
  Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[BhumikaSaini-Amazon]

Thanks @linuxpi!

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-10853-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73bbeb57a8a56de0d1f9cf69e711a8a0ff26afe5
# Push it to GitHub
git push --set-upstream origin backport/backport-10853-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-10853-to-2.x.

[linuxpi]

will raise the backport pr manually