Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] maintainers missing in codeowners #9534

Closed
dblock opened this issue Aug 24, 2023 · 10 comments · Fixed by #10681
Closed

[BUG] maintainers missing in codeowners #9534

dblock opened this issue Aug 24, 2023 · 10 comments · Fixed by #10681
Assignees
Labels
bug Something isn't working untriaged

Comments

@dblock
Copy link
Member

dblock commented Aug 24, 2023

Describe the bug

Since #9173, @abbashus and @adnapibar were re-added to MAINTAINERS, but not to CODEOWNERS. Please re-add so that they can be notified on PRs as code reviewers.

@dblock
Copy link
Member Author

dblock commented Oct 24, 2023

Seems like that's not correct.

Screenshot 2023-10-24 at 12 31 08 PM

@dblock dblock reopened this Oct 24, 2023
@msfroh
Copy link
Collaborator

msfroh commented Oct 24, 2023

Seems like that's not correct.

Screenshot 2023-10-24 at 12 31 08 PM

Hmm... is that a permissions issue on the repo?

They both exist as GitHub users:

How is write access to the repository managed? I assume a project (or repo?) admin is able to manage that. As I'm neither, I don't know who does or doesn't have write access.

@dblock
Copy link
Member Author

dblock commented Oct 30, 2023

You can ask someone to adjust permissions in the public slack, @bbarani what's the right channel?

@msfroh
Copy link
Collaborator

msfroh commented Oct 31, 2023

I talked with @prudhvigodithi -- I think the permissions were changed?

@peternied
Copy link
Member

@tlfeng @adnapibar I've sent invitations to rejoin as maintainers, sorry for the misaligned images:

image
image

@peternied
Copy link
Member

@prudhvigodithi can you investigate audit and see if there was an operation error or if this was related to another change? Maybe this had to do with them leaving the OpenSearch-Project organization.

@prudhvigodithi
Copy link
Member

prudhvigodithi commented Nov 4, 2023

Hey @peternied I ran the audit again, the only drift now for OpenSearch repo is tlfeng to be part of the collaborators with maintainer permission, should be solved once @tlfeng accept the invite as maintainer.

@tlfeng
Copy link
Collaborator

tlfeng commented Nov 6, 2023

@peternied @prudhvigodithi I accepted the invitation, and thank you for your effort. Sorry for the late reply!

@prudhvigodithi
Copy link
Member

Thanks @tlfeng I can see the OpenSearch repo is complaint now, the collaborators, code owners and maintainers are in sync now.
@dblock can we proceed to close this issue?
Thank you

@dblock
Copy link
Member Author

dblock commented Nov 7, 2023

@dblock dblock closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants