Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Follow-up][BUG] Extension requests show false timeouts on first few requests #9435

Open
DarshitChanpura opened this issue Aug 18, 2023 · 0 comments
Labels
bug Something isn't working extensions

Comments

@DarshitChanpura
Copy link
Member

This is a follow-up for #8652 to ideate and implement the solution.

During research of #8652 we discovered that the even though the extension send the response to OpenSearch, OS would still return No response.. message to the requester. Upon further analysis it was discovered that inProgressFuture.orTimeout(ExtensionsManager.EXTENSION_REQUEST_WAIT_TIMEOUT, TimeUnit.SECONDS).join(); would always timeout on trying to join() back to main threadPool. See more about this in the flow diagram in this comment: #8652 (comment)

Upon conclusion of research with @reta, it was discovered that the way RestSendToExtensionAction#prepareRequest is implemented would need some changes. These changes are proposed here: #8652 (comment)
This solution might not be a straightforward fix since Extension expects requests from OpenSearch at Transport Layer, but this issue should be used to ideate and develop the fix.

Additional context

Steps to reproduce:

[2023-07-11T19:11:12,938][INFO ][o.o.e.r.RestSendToExtensionAction] [runTask-0] Forwarding the request GET /hello to {hello-world}{hello-world}{UB8MdMJMRoGqXkceAEFC_g}{127.0.0.1}{127.0.0.1:4532}{dimrs}
[2023-07-11T19:21:22,969][INFO ][o.o.e.r.RestSendToExtensionAction] [runTask-0] Received response from extension: OK
  • After first 5-6 requests that "false" timeout after 10s, all the requests that follow should process as normal.

Logs

@DarshitChanpura DarshitChanpura added enhancement Enhancement or improvement to existing feature or request untriaged labels Aug 18, 2023
@davidlago davidlago added bug Something isn't working and removed enhancement Enhancement or improvement to existing feature or request labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working extensions
Projects
None yet
Development

No branches or pull requests

4 participants