Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate using LeafCollector::finish API in lucene for aggregation postCollection processing #9411

Open
sohami opened this issue Aug 17, 2023 · 0 comments
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations Search Search query, autocomplete ...etc

Comments

@sohami
Copy link
Collaborator

sohami commented Aug 17, 2023

Is your feature request related to a problem? Please describe.
In lucene 9.8, there is a postCollection hook added for LeafCollector to perform some processing after document collection. In OpenSearch we have postCollection implemented specifically for all the aggregation implementation via BucketCollector interface.

Describe the solution you'd like
Replace BucketCollector::postCollection with LeafCollector::finish wherever possible

Describe alternatives you've considered
N/A

Additional context
With concurrent search we made a change to call postCollection for aggregations in the executor threads instead of the main search thread as it was resulting in AssertingCodecs failure due to codec being accessed by multiple threads. Ref #8303. With this change we can remove that special handling.

@sohami sohami added enhancement Enhancement or improvement to existing feature or request untriaged Search:Aggregations Search Search query, autocomplete ...etc and removed untriaged labels Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Aggregations Search Search query, autocomplete ...etc
Projects
Status: Later (6 months plus)
Development

No branches or pull requests

1 participant