Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BWC] Temporarily Disable BWC Testing to remove stale joda flag in DocValueFormat #9349

Closed
nknize opened this issue Aug 15, 2023 · 2 comments
Closed

[BWC] Temporarily Disable BWC Testing to remove stale joda flag in DocValueFormat #9349

nknize opened this issue Aug 15, 2023 · 2 comments
Labels
backwards-compatibility enhancement Enhancement or improvement to existing feature or request Indexing:Performance Indexing Indexing, Bulk Indexing and anything related to indexing untriaged

Comments

@nknize
Copy link
Collaborator

nknize commented Aug 15, 2023

This issue is to track temporary disablement of BWC testing until ignore & removal of joda flag in DocValueFormat is backported. Back story, in Legacy 7.0 joda was removed in favor of java time to support nanoseconds properly. To support BWC in docvalues a boolean flag was added. As of Legacy 7.7 this flag is always false and can be removed.
@nknize nknize added enhancement Enhancement or improvement to existing feature or request backwards-compatibility labels Aug 15, 2023
@nknize nknize mentioned this issue Aug 15, 2023
Merged
@peternied
Copy link
Member

@nknize I'm not sure how we can know if this issue is resolved or not - in the associated PR I didn't see any tests specifically being disabled. Could you add that detail so another contributor can address and then remove the untriaged label?

@peternied peternied added Indexing Indexing, Bulk Indexing and anything related to indexing Indexing:Performance labels Nov 30, 2023
@nknize
Copy link
Collaborator Author

nknize commented Nov 30, 2023 •
edited
Loading

We opted against disabling bwc testing for that PR.. closing issue. Thx @peternied

@nknize nknize closed this as not planned Won't fix, can't repro, duplicate, stale Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backwards-compatibility enhancement Enhancement or improvement to existing feature or request Indexing:Performance Indexing Indexing, Bulk Indexing and anything related to indexing untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nknize @peternied