Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Segment_N file cleanup not happening on replicas for indexes with segrep using remote store replication #8777

Closed
ashking94 opened this issue Jul 19, 2023 · 2 comments · Fixed by #9111
Assignees
Labels
bug Something isn't working distributed framework Storage Issues and PRs relating to data and metadata storage

Comments

@ashking94
Copy link
Member

Describe the bug
Observed this issue on replica shards where the segment_N file is not getting removed even after the commits (flushes).

To Reproduce
Create index with segment replication using remote store replication. Index docs, refresh, & then flush. On the primary, the segment_N+1 would appear and segment_N would be deleted, but on replica both segment_N and segment_N+1 file shows up. If you repeat the (Index docs, refresh, & then flush), then more and more segment_N files shows up on replica.

Expected behavior
There should be only 1 segment_N file in steady state.

Plugins
Standard

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@Poojita-Raj
Copy link
Contributor

This is happening due to changes introduced by #8050 which removes replica commits and as a side-effect the cleanup of these files as part of the commit process is being skipped.

@Bukhtawar Bukhtawar added the Storage Issues and PRs relating to data and metadata storage label Jul 27, 2023
@mch2 mch2 self-assigned this Aug 8, 2023
@mch2
Copy link
Member

mch2 commented Aug 8, 2023

This will be fixed with #9111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working distributed framework Storage Issues and PRs relating to data and metadata storage
Projects
Status: Done
5 participants