Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Weighted Routing] Allow search with custom string on weighed in nodes #6297

Open
anshu1106 opened this issue Feb 13, 2023 · 0 comments
Open
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@anshu1106
Copy link
Contributor

anshu1106 commented Feb 13, 2023

Is your feature request related to a problem? Please describe.
#5873 adds support to disallow searches with preference parameter with strict weighted shard routing. On a deep dive we found that searches with custom_string helps in building shard caches across requests and Open Search dashboard extensively use this feature. Disallowing this feature entirely can affect search latencies as well.

Describe the solution you'd like
Support searches with custom string to return shard routings present in weighed in nodes. This way weighted routing is honoured and search performance is not affected. Searches targeting specific nodes PREFER_NODES, LOCAL, ONLY_LOCAL, ONLY_NODES are still not allowed.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@anshu1106 anshu1106 added enhancement Enhancement or improvement to existing feature or request untriaged labels Feb 13, 2023
@anshu1106 anshu1106 changed the title [Weighted Routing] Allow search with preference parameter on weighed in nodes [Weighted Routing] Allow search with custom string on weighed in nodes Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

2 participants