Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Weighted Routing] weighted shard routing state is not maintained across search requests #6056

Closed
anshu1106 opened this issue Jan 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@anshu1106
Copy link
Contributor

anshu1106 commented Jan 28, 2023

Describe the bug
In search requests using weighted shard routing if weights are put as (1,1,0) then the distribution of requests to data nodes is not in proportion to assigned weights. Found that data nodes in zone A had twice the requests than data nodes in zone B though weight is 1 for both the zones.

To Reproduce
Steps to reproduce the behavior:

  1. Set weighted shard routing weights using PUT api call
PUT /_cluster/routing/awareness/zone/weights
{ 
     "weights":
     {
       "zone_A": "1", 
       "zone_B": "1", 
       "zone_C": "0"
     }
     "_version" : -1
}
  1. Make 100 search requests
  2. Distribution of search request across nodes is not correct. Data nodes in zone A has twice the number of requests than data nodes in zone B which doesn't honor weighted round robin

Expected behavior
Distribution of request should be in ratio of assigned weights

Additional context
The bug got introduced with #5072 in OS 2.5 release.

@anshu1106 anshu1106 added bug Something isn't working untriaged labels Jan 28, 2023
@anshu1106 anshu1106 changed the title [BUG][Weighted Routing] eighted shard routing state across search requests [BUG][Weighted Routing] weighted shard routing state is not maintained across search requests Jan 28, 2023
@gbbafna gbbafna removed the untriaged label Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants