Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github action to ensure code coverage requirements are met #4844

Closed
dreamer-89 opened this issue Oct 20, 2022 · 3 comments
Closed

Add Github action to ensure code coverage requirements are met #4844

dreamer-89 opened this issue Oct 20, 2022 · 3 comments
Labels
CI CI related

Comments

@dreamer-89
Copy link
Member

As part of this issue, we need to add a git action to ensure code coverage requirements are met without which PR merge is blocked. The codecov integration is already done. The codecov configuration defines the config around code coverage. As part of this change, we need to add a job which ensures this configuration is honoured.

Related

#850
#1320
https://docs.codecov.com/docs/codecov-yaml

@rblcoder
Copy link

@rblcoder
Copy link

@dreamer-89 Referring to https://docs.codecov.com/docs/commit-status, any further settings to be added for https://github.com/opensearch-project/OpenSearch/blob/main/codecov.yml?
Using similar codecov.yml, I see an error here rblcoder/daily_sleep_tracker#9

@dreamer-89
Copy link
Member Author

Thanks @rblcoder for the comment. Yes, there are no changes required. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI related
Projects
None yet
Development

No branches or pull requests

3 participants