Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Zone Decommission]: Add force flag to skip the timeout for node drain during recommission #4720

Closed
pranikum opened this issue Oct 10, 2022 · 3 comments
Closed

[Zone Decommission]: Add force flag to skip the timeout for node drain during recommission #4720

pranikum opened this issue Oct 10, 2022 · 3 comments
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request

Comments

@pranikum
Copy link
Contributor

pranikum commented Oct 10, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
As per discussion on comment #4586 (comment)
Though we can achieve the force flag behavior by setting the node drain timeout to 0 in the request. Still it's better to provide support of a flag in the API so that recommission is done immediately.

Describe the solution you'd like
Provide a force flag in the API if that is enabled skip the node drain waiting process.

Describe alternatives you've considered
NA

Additional context
NA
@pranikum pranikum added enhancement Enhancement or improvement to existing feature or request untriaged labels Oct 10, 2022
@pranikum pranikum mentioned this issue Oct 10, 2022
Merged
6 tasks
@pranikum pranikum changed the title [Recommission]: Add force flag to skip the timeout for node drain during recommission [Decommission]: Add force flag to skip the timeout for node drain during recommission Oct 10, 2022
@anasalkouz
Copy link
Member

@pranikum Could you please add all issues related to Decommission project under one META issue? for better tracking.

@imRishN
Copy link
Member

imRishN commented Oct 12, 2022

@anasalkouz here is all the meta issues we are tracking for decommission project - #3957

@anasalkouz anasalkouz changed the title [Decommission]: Add force flag to skip the timeout for node drain during recommission [Zone Decommission]: Add force flag to skip the timeout for node drain during recommission Oct 19, 2022
@anasalkouz anasalkouz mentioned this issue Oct 19, 2022
Open
4 tasks
@imRishN
Copy link
Member

imRishN commented Oct 29, 2022 •
edited
Loading

We can close this issue as it has been implemented in #4586

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Bukhtawar @anasalkouz @imRishN @Rishikesh1159 @pranikum