Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Update ReplicationTarget and ReplicationListener failure exception type. #4291

Closed
Tracked by #2194
mch2 opened this issue Aug 24, 2022 · 6 comments
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. low hanging fruit

Comments

@mch2
Copy link
Member

mch2 commented Aug 24, 2022

Coming from #4278, ReplicationTarget and ReplicationListener accept OpenSearchException in their failure methods. This should be narrowed to a replication specific exception type that is used in failures from recovery / replication. Recovery already has a RecoveryFailedException, we can similarly create a ReplicationFailedException to use in the superclass.

@mch2 mch2 added enhancement Enhancement or improvement to existing feature or request distributed framework good first issue Good for newcomers low hanging fruit labels Aug 24, 2022
@sreenath-tm
Copy link

I'm interested in contributing to this issue, so before I start working it, would you mind sparing your time explaining what the fix will be like and pointing me to some resources to get started.

@dreamer-89
Copy link
Member

dreamer-89 commented Sep 9, 2022

@sreenath-tm: Apologies for the delay on response.

The suggested fix here is to create a new exception class ReplicationFailedException (? do you have a better name). This is essentially to reflect exceptions during replication as existing OpenSearchException is a base class for all OpenSearch exception and is not accurate enough. ReplicationFailedException exception can be used in ReplicationTarget and ReplicationListener instead of OpenSearchException.

I would suggest you can start with understanding about segment replication feature using design #2229
and RFC #1694

@Poojita-Raj Poojita-Raj added the hacktoberfest Global event that encourages people to contribute to open-source. label Sep 29, 2022
@ayushKataria
Copy link
Contributor

@dreamer-89 If no one else is working on this issue, I'll like to take it up as my first contribution to the project.

@dreamer-89
Copy link
Member

dreamer-89 commented Oct 6, 2022

@dreamer-89 If no one else is working on this issue, I'll like to take it up as my first contribution to the project.

Thank you @ayushKataria for the interest.
@sreenath-tm : Can you please confirm if you are still working on this issue

@dreamer-89
Copy link
Member

@sreenath-tm: Can you please confirm if you are working on this issue ? If not, @ayushKataria would like to take this forward.

@sreenath-tm
Copy link

Hi sorry for the delay in response. @ayushKataria please feel free to take it forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distributed framework enhancement Enhancement or improvement to existing feature or request good first issue Good for newcomers hacktoberfest Global event that encourages people to contribute to open-source. low hanging fruit
Projects
Status: Done
Development

No branches or pull requests

5 participants