Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Failed gradle check job reported as success on github #3506

Closed
dreamer-89 opened this issue Jun 4, 2022 · 3 comments
Closed

[Bug]: Failed gradle check job reported as success on github #3506

dreamer-89 opened this issue Jun 4, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@dreamer-89
Copy link
Member

dreamer-89 commented Jun 4, 2022

Describe the bug

Gradle check failure https://fork-jenkins.searchservices.aws.dev/job/OpenSearch_CI/job/PR_Checks/job/Gradle_Check/5766/artifact/gradle_check_5766.log has legit failures but job marked as succeeded on jenkins. It can be a legit gradle bug or scripts we have written but need some deep dive.

Identified in #3505

To reproduce

Checkout branch (dreamer-89:bulk_type_fix_2x) or changes and raise PR

Expected behavior

Job should be marked failed if there are test failures.

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

Jenkins host

Additional context

No response

Relevant log output

Tests with failures:
 - org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=bulk/11_with_deprecated_types/empty action}
 - org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=bulk/11_with_deprecated_types/List of strings}
 - org.opensearch.backwards.MixedClusterClientYamlTestSuiteIT.test {p0=bulk/11_with_deprecated_types/Array of objects}

1185 tests completed, 6 failed, 33 skipped
There were failing tests. See the report at: file:///var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/qa/mixed-cluster/build/reports/tests/v2.0.0%23mixedClusterTest/index.html

> Task :qa:mixed-cluster:v2.0.0#bwcTest
> Task :qa:mixed-cluster:bwcTestSnapshots
> Task :qa:mixed-cluster:check
build complete, generating: /var/CITOOL/workflow/OpenSearch_CI/PR_Checks/Gradle_Check/search/build/5766.tar.bz2

BUILD SUCCESSFUL in 39m
2594 actionable tasks: 2594 executed
@dreamer-89 dreamer-89 added bug Something isn't working untriaged labels Jun 4, 2022
@dreamer-89
Copy link
Member Author

The behavior is same irrespective of underlying infra.

@dreamer-89 dreamer-89 transferred this issue from opensearch-project/opensearch-build Jun 4, 2022
@tlfeng
Copy link
Collaborator

tlfeng commented Jun 4, 2022

Similar to issue #2878. I also found that gradle check passes even if YAML REST API BWC test failed. 😄

@dreamer-89
Copy link
Member Author

Thanks @tlfeng for sharing this. Closing this issue in favour of #2878

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants