Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Move query categorization to query insights plugin #14527

Closed
deshsidd opened this issue Jun 24, 2024 · 0 comments · Fixed by opensearch-project/query-insights#16
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights

Comments

@deshsidd
Copy link
Contributor

deshsidd commented Jun 24, 2024

Is your feature request related to a problem? Please describe

Query categorization changes to increment counters for search query related metrics currently resides on the search path and occurs before the request.

Describe the solution you'd like

Move these changes to the query insights plugin and make sure the incrementing of counters happens separately from the search path.

Addresses : #11596

Related component

Search:Query Insights

Describe alternatives you've considered

Another option is to keep query categorization changes as is. However, this will lead to additional overhead on the search path. Furthermore, we need to tie query latency, cpu, memory with the query categorization data which will only be possible if we increment the counters after the request is completed and the query latency and resource usage data resides inside the plugin.

To support the above and to prevent doing these counter increments on the search path, we need to move query categorization changes to the query insights plugin.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Insights
Projects
Status: Done
2 participants