Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISCUSS] Plugins: [repository-azure] support OkHttp client #1312

Open
reta opened this issue Sep 29, 2021 · 0 comments
Open

[DISCUSS] Plugins: [repository-azure] support OkHttp client #1312

reta opened this issue Sep 29, 2021 · 0 comments
Labels
enhancement Enhancement or improvement to existing feature or request

Comments

@reta
Copy link
Collaborator

reta commented Sep 29, 2021

Is your feature request related to a problem? Please describe.
In scope of the #1225, the repository-azure is switching to Azure v12 SDK, using Netty as underlying HTTP transport client. However, Azure v12 SDK also supports OkHttp client and it might be beneficial to provide the way to using this one instead.

Describe the solution you'd like
Allow to configure the underlying HTTP transport client: netty or okhttp. It should be able to be implemented as a new transport module (transport-okhttp) alternative to transport-netty4.

Describe alternatives you've considered
N/A

Additional context
Okio is leaking threads (square/okio#107) as well as OkHttp (square/okhttp#6173) so it will incur some workarounds in order to properly test Azure v12 SDK with OkHttp client.

CC @nknize

@reta reta added the enhancement Enhancement or improvement to existing feature or request label Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

1 participant