Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Tiered cache] Removal on EhcacheDiskCache key iterator doesn't work #12652

Closed
sgup432 opened this issue Mar 14, 2024 · 1 comment · Fixed by #12653
Closed

[BUG][Tiered cache] Removal on EhcacheDiskCache key iterator doesn't work #12652

sgup432 opened this issue Mar 14, 2024 · 1 comment · Fixed by #12653
Labels

Comments

@sgup432
Copy link
Contributor

sgup432 commented Mar 14, 2024

Describe the bug

EhcacheDiskCache exposes a way to iterator over keys which is basically a wrapper over underlying ehcache iterator. Link

If we try to call iterator.remove() on above iterator, it won't work as it isn't supported.

Related component

Search:Performance

To Reproduce

Write a simple unit test on EhcacheDiskCacheTests, fetch iterator and call remove(). Try to assert that the key actually got removed.

Expected behavior

Calling remove() on EhCacheKeyIterator should be able to remove the desired key.

For fix, we need to override remove() in above class.

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@sgup432
Copy link
Contributor Author

sgup432 commented Mar 14, 2024

@sohami @kiranprakash154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant