Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Segment Replication] Support random selection of replication strategy for parameterized Integ tests to run with Segment Replication #12261

Closed
Rishikesh1159 opened this issue Feb 8, 2024 · 0 comments · Fixed by #12297
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep

Comments

@Rishikesh1159
Copy link
Member

Is your feature request related to a problem? Please describe

With the current Paramterized Integ Tests, to run a test with segrep we have to run the test twice, once with docrep and another with segrep. Instead of running the test twice we need to support randomized replication strategy so that we can only run the test once but pick a replication strategy randomly.

This helps to improve test coverage and run a single test twice.

Describe the solution you'd like

I already made an attempt to support this, but faced with following problems.
-> If I make use of randomBoolean() in OpenSearchTestCase, it gives me an access denied thread error.

-> If I make use of new random() or Collections.shuffle() I get a forbidden api usage error.

The problem is with calling a random function from inside of @ParameterizedFactory(already a randomizing function) it gives access denied thread error.

We need to figure out a way to bypass this and support randomized replication strategy

Related component

Indexing:Replication

Describe alternatives you've considered

No response

Additional context

No response

@Rishikesh1159 Rishikesh1159 added enhancement Enhancement or improvement to existing feature or request untriaged labels Feb 8, 2024
@github-actions github-actions bot added the Indexing:Replication Issues and PRs related to core replication framework eg segrep label Feb 8, 2024
@Rishikesh1159 Rishikesh1159 self-assigned this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Indexing:Replication Issues and PRs related to core replication framework eg segrep
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant