Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Query Categorization] Expanding the capture of query type and level information #11364

Closed
deshsidd opened this issue Nov 28, 2023 · 5 comments · Fixed by #11582
Closed
Assignees
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities Search:Query Insights Search Search query, autocomplete ...etc

Comments

@deshsidd
Copy link
Contributor

deshsidd commented Nov 28, 2023

In Phase 1 of Search Query Categorization we captured query type and level information for a few query types.

In Phase 2 as part of this task we need to expand this to capture more query types and try to include all the aggregation query types.

After phase 2 we will be capturing query type and level information for the following query types (Including phase 1 and 2):
BoolQuery
BoostingQuery
ConstantScoreQuery
DisMaxQuery
DistanceFeatureQuery
ExistsQuery
FieldMaskingSpanQuery
FuzzyQuery
GeoBoundingBoxQuery
GeoDistanceQuery
GeoPolygonQuery
GeoShapeQuery
IntervalQuery
MatchAllQuery
MatchPhraseQuery
MatchQuery
MultiMatchQuery
PrefixQuery
QueryStringQuery
RangeQuery
RegexpQuery
ScriptQuery
SimpleQueryString
TermQuery
WildcardQuery
FunctionScoreQuery

We will be incrementing counters for each of these query types and capturing the level information as a tag to the counters. Counters will be incremented using the Telemetry metrics framework.

Phase 1: #10250
Phase 2 Meta issue : #11040
Query Visibility Roadmap : #11008

@deshsidd deshsidd added enhancement Enhancement or improvement to existing feature or request untriaged labels Nov 28, 2023
@deshsidd deshsidd self-assigned this Nov 28, 2023
@deshsidd deshsidd moved this from Todo to Now (This Quarter) in Performance Roadmap Nov 28, 2023
@getsaurabh02 getsaurabh02 moved this from Now (This Quarter) to In Progress in Performance Roadmap Nov 28, 2023
@peternied
Copy link
Member

Another example of this comment: #11367 (comment)

@deshsidd
Copy link
Contributor Author

deshsidd commented Dec 4, 2023

cc @getsaurabh02 @msfroh @backslasht Please provide some feedback.

@backslasht
Copy link
Contributor

Does phase 2 of this task include all aggregation query types? If yes, how many new metrics does it result in?

@backslasht
Copy link
Contributor

I see the list in #11366 (comment)

@backslasht
Copy link
Contributor

Will there be any over head to the request with the addition of these metrics?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request Search:Query Capabilities Search:Query Insights Search Search query, autocomplete ...etc
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants