From 5db014a097cb0dd9e767ee4619921c5e73500dff Mon Sep 17 00:00:00 2001 From: SuZhou-Joe Date: Fri, 4 Oct 2024 15:48:48 +0800 Subject: [PATCH 1/4] feat: update border style Signed-off-by: SuZhou-Joe --- .../collapsible_nav_group_enabled.test.tsx.snap | 9 --------- .../chrome/ui/header/collapsible_nav_group_enabled.scss | 3 +-- .../chrome/ui/header/collapsible_nav_group_enabled.tsx | 1 - 3 files changed, 1 insertion(+), 12 deletions(-) diff --git a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav_group_enabled.test.tsx.snap b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav_group_enabled.test.tsx.snap index 74dfa496c9cb..c3159005c50b 100644 --- a/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav_group_enabled.test.tsx.snap +++ b/src/core/public/chrome/ui/header/__snapshots__/collapsible_nav_group_enabled.test.tsx.snap @@ -63,9 +63,6 @@ exports[` should render correctly 1`] = ` -
@@ -87,9 +84,6 @@ exports[` should render correctly 2`] = `
-
@@ -161,9 +155,6 @@ exports[` should show use case nav when current na
-
diff --git a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss index e410361bef86..72c9245df561 100644 --- a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss +++ b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss @@ -102,11 +102,10 @@ } &.bottom-container-expanded { - @include euiBottomShadowLarge($euiColorMediumShade, 0.1, true, true); - gap: 16px; padding-top: $euiSizeM; padding-bottom: $euiSizeM; + border-top: $euiBorderThin; } } diff --git a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx index c9e2752055e1..995cf2fe62a3 100644 --- a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx +++ b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx @@ -250,7 +250,6 @@ export function CollapsibleNavGroupEnabled({ // This element is used to push icons to the bottom of left navigation when collapsed !isNavOpen ?
: null } -
Date: Fri, 4 Oct 2024 07:51:07 +0000 Subject: [PATCH 2/4] Changeset file for PR #8489 created/updated --- changelogs/fragments/8489.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/8489.yml diff --git a/changelogs/fragments/8489.yml b/changelogs/fragments/8489.yml new file mode 100644 index 000000000000..6e31211c8efd --- /dev/null +++ b/changelogs/fragments/8489.yml @@ -0,0 +1,2 @@ +feat: +- Update border style when new left nav expanded ([#8489](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8489)) \ No newline at end of file From 876e167a1d2bec735bd872a33da6b021bad4ab55 Mon Sep 17 00:00:00 2001 From: SuZhou-Joe Date: Fri, 4 Oct 2024 16:09:51 +0800 Subject: [PATCH 3/4] feat: update Signed-off-by: SuZhou-Joe --- .../chrome/ui/header/collapsible_nav_group_enabled.tsx | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx index 995cf2fe62a3..66257eb48d7b 100644 --- a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx +++ b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.tsx @@ -4,14 +4,7 @@ */ import './collapsible_nav_group_enabled.scss'; -import { - EuiFlyout, - EuiPanel, - EuiHorizontalRule, - EuiHideFor, - EuiFlyoutProps, - EuiShowFor, -} from '@elastic/eui'; +import { EuiFlyout, EuiPanel, EuiHideFor, EuiFlyoutProps, EuiShowFor } from '@elastic/eui'; import { i18n } from '@osd/i18n'; import React, { useMemo } from 'react'; import useObservable from 'react-use/lib/useObservable'; From 6663fd47b70caf75ecb102e8782ef8823e42e39e Mon Sep 17 00:00:00 2001 From: SuZhou-Joe Date: Fri, 4 Oct 2024 22:45:33 +0800 Subject: [PATCH 4/4] feat: update border color Signed-off-by: SuZhou-Joe --- .../public/chrome/ui/header/collapsible_nav_group_enabled.scss | 1 + 1 file changed, 1 insertion(+) diff --git a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss index 72c9245df561..c04d21131e5f 100644 --- a/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss +++ b/src/core/public/chrome/ui/header/collapsible_nav_group_enabled.scss @@ -106,6 +106,7 @@ padding-top: $euiSizeM; padding-bottom: $euiSizeM; border-top: $euiBorderThin; + border-color: $euiColorMediumShade; } }