From 1e3b3e34b6972bc4afbb314d361632496755bce0 Mon Sep 17 00:00:00 2001 From: yubonluo Date: Tue, 23 Jul 2024 15:29:44 +0800 Subject: [PATCH 1/2] No restriction on setting default data source Signed-off-by: yubonluo --- .../edit_data_source/components/header/header.test.tsx | 3 --- .../components/edit_data_source/components/header/header.tsx | 4 +--- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.test.tsx b/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.test.tsx index 4953e21647c7..4bcfb436d529 100644 --- a/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.test.tsx +++ b/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.test.tsx @@ -205,8 +205,5 @@ describe('Datasource Management: Edit Datasource Header', () => { expect(component.find(headerTitleIdentifier).last().text()).toBe(dataSourceName); expect(component.find(deleteIconIdentifier).exists()).toBe(false); }); - test('should not show default icon', () => { - expect(component.find(setDefaultButtonIdentifier).exists()).toBe(false); - }); }); }); diff --git a/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx b/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx index 2a9fee012e7c..8e016a80299e 100644 --- a/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx +++ b/src/plugins/data_source_management/public/components/edit_data_source/components/header/header.tsx @@ -177,9 +177,7 @@ export const Header = ({ {/* Test default button */} - {canManageDataSource ? ( - {renderDefaultIcon()} - ) : null} + {renderDefaultIcon()} {/* Test connection button */} {renderTestConnectionButton()} {/* Delete icon button */} From 8b1a82e0f89a5f98199b770d084e5db2639ee7e4 Mon Sep 17 00:00:00 2001 From: "opensearch-changeset-bot[bot]" <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Date: Tue, 23 Jul 2024 07:37:02 +0000 Subject: [PATCH 2/2] Changeset file for PR #7396 created/updated --- changelogs/fragments/7396.yml | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 changelogs/fragments/7396.yml diff --git a/changelogs/fragments/7396.yml b/changelogs/fragments/7396.yml new file mode 100644 index 000000000000..db310ba049dd --- /dev/null +++ b/changelogs/fragments/7396.yml @@ -0,0 +1,2 @@ +fix: +- [DataSource] No restriction on setting default data source ([#7396](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7396)) \ No newline at end of file