Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Remove references to the deprecated v8 and amsterdam of OUI #3571

Open
AMoo-Miki opened this issue Mar 9, 2023 · 3 comments
Open

[BUG] Remove references to the deprecated v8 and amsterdam of OUI #3571

AMoo-Miki opened this issue Mar 9, 2023 · 3 comments
Labels
bug Something isn't working OUI Issues that require migration to OUI

Comments

@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Mar 9, 2023

Describe the bug

OUI will be removing the deprecated theme files in their next minor release which would break builds.

@AMoo-Miki AMoo-Miki added bug Something isn't working untriaged and removed untriaged labels Mar 9, 2023
@Nicksqain
Copy link
Contributor

Do we need to remove this all in 2.6 ( for 2.7 in next?)

@joshuarrrr
Copy link
Member

As with most PRs, we'll start with PRs against main, and maintainers will then backport to active release branches as necessary.

@joshuarrrr
Copy link
Member

joshuarrrr commented Mar 9, 2023

Removing amsterdam references should be relatively straightforward: https://github.com/search?q=repo%3Aopensearch-project%2FOpenSearch-Dashboards%20amsterdam&type=code

Finding v8 theme references will need a bit more care, because there's also plenty of comments and codes that use v8 in other contexts (JS engines, node, etc.).

@seanneumann seanneumann added the OUI Issues that require migration to OUI label May 18, 2023
@rednaksi91 rednaksi91 moved this to Todo in Look & Feel May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OUI Issues that require migration to OUI
Projects
Status: Todo
Development

No branches or pull requests

4 participants