Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Visualizations] Adds visConfig.title and uiState to build pipeline function #2272

Merged
merged 2 commits into from
Sep 7, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 140c56f from #2192

@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner September 6, 2022 17:57
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (2.x@278c77f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 140c56f differs from pull request most recent head a00388a. Consider uploading reports for the commit a00388a to get more accurate results

@@          Coverage Diff           @@
##             2.x    #2272   +/-   ##
======================================
  Coverage       ?   66.77%           
======================================
  Files          ?     3133           
  Lines          ?    60079           
  Branches       ?     9152           
======================================
  Hits           ?    40117           
  Misses         ?    17771           
  Partials       ?     2191           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

joshuarrrr
joshuarrrr previously approved these changes Sep 6, 2022
…unction (#2192)

In pipeline building, this PR adds `visConfig.title` and `uiState` properties for "visualization" function.

This aims 2 goals:
-    To be consistent with pipelines built with "buildPipelineVisFunction".
-    To provide "title" and "uiState" informations for visualizations.

This is currently a missing information for community plugins.

Signed-off-by: fbaligand <[email protected]>

Signed-off-by: fbaligand <[email protected]>
(cherry picked from commit 140c56f)
@ananzh ananzh merged commit b57208f into 2.x Sep 7, 2022
@joshuarrrr joshuarrrr deleted the backport/backport-2192-to-2.x branch September 7, 2022 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants