Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] The Exclamation Circle icon is currently represented by a triangle #8683

Open
marcio-pessoa opened this issue Oct 22, 2024 · 2 comments
Labels
bug Something isn't working OUI Issues that require migration to OUI

Comments

@marcio-pessoa
Copy link

Describe the bug

The Exclamation Circle icon is currently represented by a triangle, the same of Exclamation triangle.

To Reproduce
Steps to reproduce the behavior:

  1. Go to any or new Time Series TSVB,
  2. Click on Annotations,
  3. Click on Icon,
  4. Scroll down to Exclamation Circle
  5. See error

Expected behavior
The Exclamation Circle must be represented by a circle (not a triangle).

OpenSearch Version
v 2.16.0.

Dashboards Version
v 2.16.0.

Screenshots
Screenshot from 2024-10-22 16-58-04

Host/Environment (please complete the following information):

  • Server: Amazon Linux release 2023.5.20240805 (Amazon Linux)
  • Client: Ubuntu Linux 24.04 LTS
  • Google Chrome Version 129.0.6668.100 (Official Build) (64-bit)
@marcio-pessoa marcio-pessoa added bug Something isn't working untriaged labels Oct 22, 2024
@abbyhu2000
Copy link
Member

abbyhu2000 commented Oct 29, 2024

@marcio-pessoa Thanks!

currently we use both the icon 'alert' for exclamation Circle and exclamation triangle, so they look the same. I think this is a todo for OUI to add a exclamation in circle icon since currently we do not have one: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/vis_type_timeseries/public/application/visualizations/constants/icons.js#L59

cc: @ashwin-pc

@abbyhu2000 abbyhu2000 added OUI Issues that require migration to OUI and removed untriaged labels Oct 29, 2024
@canascar
Copy link
Member

canascar commented Nov 1, 2024

UX can add this icon to the todo list @abbyhu2000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OUI Issues that require migration to OUI
Projects
None yet
Development

No branches or pull requests

3 participants