Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Multiple Datasource] Data source multi selectable component should return the selected data sources and return to the callback function after initial load #6324

Closed
Tracked by #5872
BionIT opened this issue Apr 3, 2024 · 2 comments · Fixed by #6333
Assignees
Labels
enhancement New feature or request multiple datasource multiple datasource project untriaged v2.14.0

Comments

@BionIT
Copy link
Collaborator

BionIT commented Apr 3, 2024

Is your feature request related to a problem? Please describe.
Currently, search relevance plugin and query workbench plugin would use the multi selectable component as a filter, and by requirements, the multi selectable will select all data sources by default, however the selected data sources are not passed to callback function until there is a change event.

Describe the solution you'd like
Multi selectable component should pass selected data sources on the initial load to the call back function

Describe alternatives you've considered
Instead of select all options, do not select any options as the default state, then that means user need to always make a selection first

Additional context

Add any other context or screenshots about the feature request here.

@BionIT BionIT added enhancement New feature or request multiple datasource multiple datasource project labels Apr 3, 2024
@BionIT BionIT added the v2.14.0 label Apr 3, 2024
@huyaboo
Copy link
Member

huyaboo commented Apr 3, 2024

Taking a look

@BionIT
Copy link
Collaborator Author

BionIT commented Apr 3, 2024

Thanks @huyaboo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request multiple datasource multiple datasource project untriaged v2.14.0
Projects
Status: Planned work items
2 participants