Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Discover routing without query params does not route correctly #5774

Closed
ashwin-pc opened this issue Feb 1, 2024 · 1 comment · Fixed by #5776
Closed

[BUG] Discover routing without query params does not route correctly #5774

ashwin-pc opened this issue Feb 1, 2024 · 1 comment · Fixed by #5776
Assignees
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent

Comments

@ashwin-pc
Copy link
Member

Describe the bug

Wen visiting the single document or context pages, if the url does not contain query parameters, the routing breaks. e.g.

# Works
http://localhost:5601/app/discover#/context/90943e30-9a47-11e8-b64d-95841ca0b247/oyj5iIwBAXmWFklaNiuy?

# Does not work
http://localhost:5601/app/discover#/context/90943e30-9a47-11e8-b64d-95841ca0b247/oyj5iIwBAXmWFklaNiuy

The issue is with how discover maps the legacy URL's to the new data explorer route. The url parameters after the ? are optional, but the regex currently requires the ? to be present to route the URL correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Routes http://localhost:5601/app/discover#/context/<doc-id>/<index-id> correctly

OpenSearch Version
Please list the version of OpenSearch being used.

Dashboards Version
Please list the version of OpenSearch Dashboards being used.

Plugins

Please list all plugins currently enabled.

Screenshots

If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@ashwin-pc ashwin-pc added bug Something isn't working untriaged discover for discover reinvent data explorer Issues related to the Data Explorer project and removed untriaged labels Feb 1, 2024
@abbyhu2000 abbyhu2000 self-assigned this Feb 1, 2024
@ananzh
Copy link
Member

ananzh commented Feb 7, 2024

close this since it is fixed in 2.12

@ananzh ananzh closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data explorer Issues related to the Data Explorer project discover for discover reinvent
Projects
None yet
3 participants