Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasources] Address Remaining Items in Datasource Selector #5211

Closed
mengweieric opened this issue Oct 4, 2023 · 3 comments · Fixed by #6571
Closed

[Datasources] Address Remaining Items in Datasource Selector #5211

mengweieric opened this issue Oct 4, 2023 · 3 comments · Fixed by #6571
Labels
data explorer Issues related to the Data Explorer project enhancement New feature or request v2.14.0

Comments

@mengweieric
Copy link
Collaborator

mengweieric commented Oct 4, 2023

Is your feature request related to a problem? Please describe.

Due to time constraints, some review comments have not been addressed. This issue is for tracking those remaining tasks need to be addressed in the PR #5167 .

Describe the solution you'd like

Addressing all reviews after the merge, including:
- add / improve interfaces and types
- code movement of datasource registration from discover to data plugin

  • Adjustments for datasource API definitions
    • removing multiple selectable API
    • add type to datasource and remove hardcoding type name mapping
      - using i18n for user facing text
  • Unit / E2E test coverage
@mengweieric mengweieric added the enhancement New feature or request label Oct 4, 2023
@anirudha
Copy link

anirudha commented Oct 4, 2023

lets target this at 2.12 or sooner

@anirudha
Copy link

anirudha commented Oct 4, 2023

In the next release we should move this to the view-switcher asap

@mengweieric
Copy link
Collaborator Author

Spoke with @ashwin-pc on this issue that we will:

  • Remove this issue from 2.12 release
  • Add tests to datasource code lines that still need coverages
  • Make change to datasource interface addressing item 'Adjustments for datasource API definitions' after 2.12 when we'd settled new datasource interface designs

@ashwin-pc ashwin-pc added v2.13.0 and removed v2.12.0 labels Feb 7, 2024
@ashwin-pc ashwin-pc added v2.14.0 and removed v2.13.0 labels Mar 19, 2024
@kavilla kavilla linked a pull request Apr 29, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data explorer Issues related to the Data Explorer project enhancement New feature or request v2.14.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants