Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Multiline content in [message] field is not displayed correctly #5208

Closed
vinylen opened this issue Oct 4, 2023 · 7 comments
Closed
Assignees
Labels
bug Something isn't working discover for discover reinvent good first issue Good for newcomers v2.12.0

Comments

@vinylen
Copy link

vinylen commented Oct 4, 2023

Describe the bug

With the new discover UI we are unable to see multiline messages in a coherent way. Multiline messages just gets "stretched" out, never word wrapped. When switching back to the old discover UI, multiline messages gets displayed in a better way.

To Reproduce
Have multiline content in a field, toggle that field so that it is shown in the new discover UI

Expected behavior
Multiline messages should get displayed in the same way as before, showing a few lines.

OpenSearch Version
2.10

Dashboards Version
2.10

Plugins

opensearch-prometheus-exporter
s3-repository

Screenshots
New discover with multiline content, everything is just in a single row.
image

Old discover with multiline content:
image

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Browser and version [e.g. 22]

Additional context

Add any other context about the problem here.

@vinylen vinylen added bug Something isn't working untriaged labels Oct 4, 2023
@ananzh ananzh added discover for discover reinvent good first issue Good for newcomers v2.12.0 and removed untriaged labels Oct 10, 2023
@MadaniKK
Copy link
Contributor

Hi, can I take this issue? Thank you

@joshuarrrr
Copy link
Member

This may need to be fixed in the OUIDataGrid component.

@ananzh
Copy link
Member

ananzh commented Oct 25, 2023

I think the bug is that in new Discover nested field is not correctly shown in left field nav. Here is how to reproduce it:

  • step 1: go to dev tools. create an index and add nested field.
PUT test-2/_doc/1
{
  "products": [
    {
      "base_price": 28.99,
      "discount_percentage": 0,
      "quantity": 1,
      "manufacturer": "Tigress Enterprises"
    },
    {
      "base_price": 32.99,
      "discount_percentage": 0,
      "quantity": 1,
      "manufacturer": "Oceanavigations"
    }
  ]
}

PUT test-2/_doc/2
{
  "products": [
    {
      "base_price": 31.14,
      "discount_percentage": 5,
      "quantity": 1,
      "manufacturer": "Virora"
    },
    {
      "base_price": 35.69,
      "discount_percentage": 10,
      "quantity": 3,
      "manufacturer": "Oceanavigations"
    }
  ]
}

  • step 2: go to Dashboards management --> Index patterns --> create index pattern
Screenshot 2023-10-25 at 12 49 21
  • step 3: enter test* to match test-2
  • go back to discover. in the index pattern selector (on top of left nav), choose test*.

So in new Discover (2.11), if you check the left field nav, you could see we miss the nested fieldproducts. but the flyout and display are fine. It is just that there is no way customer could select nested field.

Screenshot 2023-10-25 at 12 37 29

But if we do the above steps in 2.9 OSD with legacy discover, we could see products in left nav and once click + button to select it, you could see multiple lines in each row as customer shown.

Screenshot 2023-10-25 at 12 13 16 Screenshot 2023-10-25 at 12 44 11 Screenshot 2023-10-25 at 12 45 34

I think we need to first solve the nested field not picked up by left nav then verify if we see multiline issue after select the nested field.

@MadaniKK
Copy link
Contributor

MadaniKK commented Oct 26, 2023

Thank you for the detailed steps for reproducing the bug! Now I definitely understand more of the bug! Which parts of the codes should I first try to look into? left field Nav and Datagrid? Also, what is the quickest way to be able to look at the legacy discover (2.9 OSD)

@MadaniKK
Copy link
Contributor

This issue is blocked by issue #5400

@ananzh
Copy link
Member

ananzh commented Nov 15, 2023

resolved by #5429
now, given this fix, nested field in the object will be added as a separate field in side nav and table.

@vinylen if there is more issues, pls reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working discover for discover reinvent good first issue Good for newcomers v2.12.0
Projects
None yet
Development

No branches or pull requests

4 participants