Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cypress12] Ensure cypress functional tests run with Cypress12 #4813

Closed
cwperks opened this issue Aug 24, 2023 · 5 comments
Closed

[Cypress12] Ensure cypress functional tests run with Cypress12 #4813

cwperks opened this issue Aug 24, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@cwperks
Copy link
Member

cwperks commented Aug 24, 2023

The opensearch-dashboards-functional-test repo is working on upgrading the version of Cypress used in the repo from v9 to v12.

There is a feature branch in the repository called feature/cypress12 to work on the upgrade and ensure that all repositories that have functional tests in the repo can verify that their tests run successfully with the upgraded version of cypress. If any updates to tests are required please submit a PR against the function test repo and base the PR on the feature/cypress12 branch to show the tests running with the upgraded version of Cypress.

Please refer to the migration guide from Cypress to reference when updating tests.

If no work is required to update the tests then please close this issue and indicate that no update is required.

@AMoo-Miki
Copy link
Collaborator

This has a wide blast radius, impacting plugins too.

@cwperks
Copy link
Member Author

cwperks commented Aug 29, 2023

@AMoo-Miki This is part of a greater META issue where I have filed issues on all dashboards plugin repos that have cypress tests. There is a feature branch in opensearch-dashboards-functional-test repo (feature/cypress12) where plugins can submit PRs to make any modifications needed in their tests to be compatible with Cypress 12.

Once all plugin repos have time to react, I plan to create a PR to merge the feature/cypress12 branch of opensearch-dashboards-functional-tests into main for that repo.

@d-rowe
Copy link
Member

d-rowe commented Dec 3, 2024

Hey @cwperks I've addressed in #8995. This repo is now upgraded to Cypress v12.

@cwperks
Copy link
Member Author

cwperks commented Dec 3, 2024

Hey @cwperks I've addressed in #8995. This repo is now upgraded to Cypress v12.

Will the upgrade be backported to 2.x?

@d-rowe
Copy link
Member

d-rowe commented Dec 4, 2024

We're not planning on it given there's a number of breaking changes across these 3 versions that could affect others. Happy to discuss and understand further though if y'all have a need for this in 2.X.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants