Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis Augmenter] Un-skip tests with temporal issues #4555

Open
ohltyler opened this issue Jul 12, 2023 · 1 comment
Open

[Vis Augmenter] Un-skip tests with temporal issues #4555

ohltyler opened this issue Jul 12, 2023 · 1 comment
Assignees

Comments

@ohltyler
Copy link
Member

There are current tests that are skipped due to the snapshots failing when running in envs in different time zones. See https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/vis_type_vega/public/expressions/helpers.test.js#L194

These should be updated to not include a snapshot, or potentially enforce time zones when running these somehow.

@kavilla
Copy link
Member

kavilla commented Jul 12, 2023

I like the first option and I do believe there is an issue open for in general to migrate away from snapshots within this repo since it makes the test too brittle based on the output. Like caniuse will output it is out of date some times and it will fail a snapshot test because the actual included the warning message with the other values. Snapshots help us writes test fast but cause issues like this.

#2329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants