Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look & Feel] Add dark mode option that respects browser settings #4462

Closed
joshuarrrr opened this issue Jun 30, 2023 · 0 comments · Fixed by #5652
Closed

[Look & Feel] Add dark mode option that respects browser settings #4462

joshuarrrr opened this issue Jun 30, 2023 · 0 comments · Fixed by #5652
Labels
next-theme OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks v2.14.0

Comments

@joshuarrrr
Copy link
Member

Administrators should have to option to configure OpenSearch Dashboards to respect individual user browser settings for light mode/dark mode.

Currently, switching between light and dark mode theme variants can only be done via the Advanced Settings. Whichever mode is selected affects all users of that instance, regardless of their own preferences or system settings. We'd like to add a third option to that setting "Respect user browser settings", which would allow user preferences to override the default light/dark behavior.

Ideally, if users have their system or browser configured to switch between light and dark mode at various times of day, the application would adjust automatically. But due to the current implementation, we'll start with the requirement that at page load/refresh, the application gets dark/light mode preferences from the browser and uses the preferred theme accordingly.

In absence of any user/browser preferences, dark mode will be used by default.

Related:
#4454

@joshuarrrr joshuarrrr added OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks and removed untriaged labels Jun 30, 2023
@joshuarrrr joshuarrrr moved this to Todo in Look & Feel Aug 9, 2023
@joshuarrrr joshuarrrr moved this from Todo to Blocked in Look & Feel Sep 15, 2023
@wbeckler wbeckler removed the v2.12.0 label Feb 19, 2024
@github-project-automation github-project-automation bot moved this from Blocked to Done in Look & Feel Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-theme OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks v2.14.0
Projects
Status: Done
3 participants