Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vis colors] Replace vis_type_timeline colors with ouiPaletteColorBlind() #4322

Closed
Tracked by #4318
joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Closed
Tracked by #4318

[Vis colors] Replace vis_type_timeline colors with ouiPaletteColorBlind() #4322

joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Assignees
@manasvinibs
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks timeline unified visualization UX

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 19, 2023 •
edited
Loading

The Timeline visualization (vis_type_timeline) defines its own categorical palette that doesn't match any other visualization or use OUI colors: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/vis_type_timeline/public/helpers/panel_utils.ts#L68-L79

(For visual comparison, see opensearch-project/oui#601)

Instead of a hard-coded list, it should just use the default OUI colors from euiPaletteColorBlind()
@joshuarrrr joshuarrrr mentioned this issue Jun 19, 2023
Open
17 tasks
@joshuarrrr joshuarrrr added timeline unified visualization UX OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks labels Jun 19, 2023
@joshuarrrr joshuarrrr moved this to Todo in Look & Feel Jun 19, 2023
@manasvinibs manasvinibs mentioned this issue Jun 22, 2023
Merged
8 tasks
@joshuarrrr joshuarrrr moved this from Todo to In Progress in Look & Feel Jun 23, 2023
@joshuarrrr
Copy link
Member Author

closed via #4366

@github-project-automation github-project-automation bot moved this from In Progress to Done in Look & Feel Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manasvinibs manasvinibs

Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks timeline unified visualization UX
Projects
Look & Feel
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshuarrrr @manasvinibs