Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis colors] Update legacy mapped colors in charts plugin to use ouiPaletteColorBlind() #4320

Closed
Tracked by #4318
joshuarrrr opened this issue Jun 19, 2023 · 1 comment
Assignees
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX

Comments

@joshuarrrr
Copy link
Member

joshuarrrr commented Jun 19, 2023

A number of OpenSearch Dashboards visualization typesx (VisLib Area, VisLib Pie, VisLib Horizontal Bar, VisLib Line, VisLib Vertical Bar, and TSVB as a fallback) use legacy mapped colors from https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/charts/public/services/colors/color_palette.ts

(See opensearch-project/oui#601 for a visual output comparison)

These mapped colors don't rotate particularly well, because they tend to generate very similar colors. As part of this issue we may also consider getting rid of the entire mapped colors system, as bugs in its implementation leads to undesired behavior (colors that change on dashboard refresh and unexpected statefulness of visualizations).

@joshuarrrr
Copy link
Member Author

closed via #4398

@github-project-automation github-project-automation bot moved this from Todo to Done in Look & Feel Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OUI compliance Issues and PRs to maximize OUI usage and remove style and component hacks unified visualization UX
Projects
Status: Done
Development

No branches or pull requests

2 participants