Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Anywhere] Fix legacy tests #4310

Closed
8 tasks done
ohltyler opened this issue Jun 19, 2023 · 5 comments
Closed
8 tasks done

[Feature Anywhere] Fix legacy tests #4310

ohltyler opened this issue Jun 19, 2023 · 5 comments

Comments

@ohltyler
Copy link
Member

ohltyler commented Jun 19, 2023

Goal is to get feature branch have all consistent passing CI workflows. This is a requirement for merging into main/2.x.

Broken tests on feature/feature-anywhere branch as of 6/19 (ref)

  • group 2 (linux + windows) (2 failing on main)
  • group 3 (linux + windows)
  • group 6 (linux + windows) (6 failing on main)
  • group 7 (linux + windows)
  • group 9 (linux + windows) (1 failing on main)
  • group 10 (linux + windows) (18 failing on main) (13 when re-running, probably flaky and some succeeded in my run)
  • group 11 (linux + windows) (8 failing on main)
  • group 12 (linux + windows) (14 failing on main)

Failures in main based off of this run on 6/20 from #4268

@ohltyler
Copy link
Member Author

ohltyler commented Jun 21, 2023

After initial fixes in #4477: Still seeing failures for:

  • CI 6 (9 failures vs. 6 on main, 6 consistently)
  • CI 7 (4 failures vs. 0 on main)
  • CI 12 (15 failures vs. 14 on main, 14 consistently)

Ref run: https://github.com/opensearch-project/OpenSearch-Dashboards/actions/runs/5328885666/jobs/9653998014

I will run all of these on my local to see which are flaky or which are actual failures

Sorry, something went wrong.

@ohltyler
Copy link
Member Author

ohltyler commented Jun 21, 2023

Able to reproduce group 7 failures locally - looking into it

@ohltyler
Copy link
Member Author

After latest commit in PR above ^ only same errors seen as on main are left.

@joshuarrrr
Copy link
Member

@ohltyler Can this be closed via #4327 ?

@ohltyler
Copy link
Member Author

ohltyler commented Jul 5, 2023

Yes

@ohltyler ohltyler closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants